-
Couldn't load subscription status.
- Fork 115
Adding specification for the get random sample and get random sample stats APIs #5528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Following you can find the validation changes against the target branch for the APIs.
You can validate these APIs yourself by using the |
specification/_doc_ids/table.csv
Outdated
| delete-query-rule-from-ui,https://www.elastic.co/docs/solutions/search/query-rules-ui#delete-a-rule,,Delete a rule from the Query Rules UI | ||
| list-query-rules-in-ui,https://www.elastic.co/docs/solutions/search/query-rules-ui#accessing-the-query-rules-ui,,See rules and rulesets in Query Rules UI | ||
| delete-query-ruleset-from-ui,https://www.elastic.co/docs/solutions/search/query-rules-ui#delete-a-ruleset,,Delete a ruleset from the Query Rules UI | ||
| random_sample,https://www.elastic.co/guide/en/elasticsearch/reference/{branch}/ingest-random-sampling.html,, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this part generated? seems like this isnt a valid url
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah sorry, I copied that pattern from an old PR. It looks like the URLs are different now, so I've made it look more like other ones. Hopefully someone from the docs team can chime in if that's wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one comment, but if that's correct we can merge this.
| * Request for a random sample of raw documents ingested into the given index or data stream. | ||
| * | ||
| * @rest_spec_name indices.get_sample | ||
| * @availability serverless visibility=feature_flag feature_flag=random_sampling since=9.3.0 stability=experimental |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to clarify: this @availability annotation will make this API available in serverless only. It will show up in the clients as not supported for stack unless you also add a stack @availability annotation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh that's definitely not what I want!
This adds the elasticsearch-specification for
GET {index}/_sampleandGET {index}/_sample/stats.