Fix UserAgentProcessor properties default values #5758
Merged
+10
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Following you can find the validation changes against the target branch for the APIs. No changes detected. You can validate these APIs yourself by using the |
Anaethelion
approved these changes
Nov 27, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
(cherry picked from commit 161789d)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
(cherry picked from commit 161789d)
github-actions bot
pushed a commit
that referenced
this pull request
Nov 27, 2025
(cherry picked from commit 161789d)
pquentin
added a commit
that referenced
this pull request
Nov 28, 2025
(cherry picked from commit 161789d) Co-authored-by: Quentin Pradet <[email protected]>
pquentin
added a commit
that referenced
this pull request
Nov 28, 2025
(cherry picked from commit 161789d) Co-authored-by: Quentin Pradet <[email protected]>
pquentin
added a commit
that referenced
this pull request
Nov 28, 2025
(cherry picked from commit 161789d) Co-authored-by: Quentin Pradet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, all properties are used: https://github.com/elastic/elasticsearch/blob/c21fc968d4180b025e2be2eb1bd7a4b503aeffbd/modules/ingest-user-agent/src/main/java/org/elasticsearch/ingest/useragent/UserAgentProcessor.java#L236-L238
I fixed the enum in #2854, but did not update the default values. More validation would be useful here.