Fix testScheduledFixedDelayRejection (#106630) (#106643)

Not really necessary to allow the scheduled task to race against the
blocks, and this race is a source of test flakiness. Fixed by imposing
the blocks first.

Closes #106618

Author: DaveCTurner

server/src/test/java/org/elasticsearch/threadpool/ThreadPoolTests.java

@@ -358,7 +358,6 @@ public void testScheduledOneShotForceExecution() {
         }
     }
 
-    @AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/106618")
     public void testScheduledFixedDelayRejection() {
         final String name = "fixed-bounded";
         final ThreadPool threadPool = new TestThreadPool(
@@ -369,17 +368,14 @@ public void testScheduledFixedDelayRejection() {
         final PlainActionFuture<Void> future = new PlainActionFuture<>();
         final CountDownLatch latch = new CountDownLatch(1);
         try {
+            blockExecution(threadPool.executor(name), latch);
             threadPool.scheduleWithFixedDelay(
-                ActionRunnable.wrap(future, ignored -> Thread.yield()),
+                ActionRunnable.wrap(future, ignored -> fail("should not execute")),
                 TimeValue.timeValueMillis(between(1, 100)),
                 name
             );
 
-            while (future.isDone() == false) {
-                // might not block all threads the first time round if the scheduled runnable is running, so must keep trying
-                blockExecution(threadPool.executor(name), latch);
-            }
-            expectThrows(EsRejectedExecutionException.class, () -> FutureUtils.get(future));
+            expectThrows(EsRejectedExecutionException.class, () -> FutureUtils.get(future, 10, TimeUnit.SECONDS));
         } finally {
             latch.countDown();
             assertTrue(terminate(threadPool));