Skip to content

Commit 025f6bb

Browse files
authored
Add IndicesMetrics instead of IndicesService to toClose (#114782)
The same line already exists in [L543](https://github.com/ywangd/elasticsearch/blob/9f4a7927bdc366f8ca98c4652ac7d1102d9430f5/server/src/main/java/org/elasticsearch/node/Node.java#L543). It should have no practial impact since AbstractLifecycleComponent#close short-circuits if its lifecycle is already closed. The original code meant to close IndicesMetrics. This PR adds it. Relates: #113737
1 parent 6c752ab commit 025f6bb

File tree

1 file changed

+1
-1
lines changed
  • server/src/main/java/org/elasticsearch/node

1 file changed

+1
-1
lines changed

server/src/main/java/org/elasticsearch/node/Node.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -561,7 +561,7 @@ public synchronized void close() throws IOException {
561561
toClose.add(() -> stopWatch.stop().start("transport"));
562562
toClose.add(injector.getInstance(TransportService.class));
563563
toClose.add(injector.getInstance(NodeMetrics.class));
564-
toClose.add(injector.getInstance(IndicesService.class));
564+
toClose.add(injector.getInstance(IndicesMetrics.class));
565565
if (ReadinessService.enabled(environment)) {
566566
toClose.add(injector.getInstance(ReadinessService.class));
567567
}

0 commit comments

Comments
 (0)