Skip to content

Commit 02c5a51

Browse files
Avoid re-enqueueing merge tasks
1 parent 6bf55e4 commit 02c5a51

File tree

2 files changed

+2
-13
lines changed

2 files changed

+2
-13
lines changed

muted-tests.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -380,9 +380,6 @@ tests:
380380
- class: org.elasticsearch.xpack.esql.qa.single_node.EsqlSpecIT
381381
method: test {lookup-join.MvJoinKeyFromRow ASYNC}
382382
issue: https://github.com/elastic/elasticsearch/issues/130642
383-
- class: org.elasticsearch.index.engine.ThreadPoolMergeExecutorServiceDiskSpaceTests
384-
method: testUnavailableBudgetBlocksNewMergeTasksFromStartingExecution
385-
issue: https://github.com/elastic/elasticsearch/issues/130205
386383
- class: org.elasticsearch.indices.stats.IndexStatsIT
387384
method: testFilterCacheStats
388385
issue: https://github.com/elastic/elasticsearch/issues/124447

server/src/test/java/org/elasticsearch/index/engine/ThreadPoolMergeExecutorServiceDiskSpaceTests.java

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -771,16 +771,8 @@ public void testUnavailableBudgetBlocksNewMergeTasksFromStartingExecution() thro
771771
while (submittedMergesCount > 0 && expectedAvailableBudget.get() > 0L) {
772772
ThreadPoolMergeScheduler.MergeTask mergeTask = mock(ThreadPoolMergeScheduler.MergeTask.class);
773773
when(mergeTask.supportsIOThrottling()).thenReturn(randomBoolean());
774-
doAnswer(mock -> {
775-
Schedule schedule = randomFrom(Schedule.values());
776-
if (schedule == BACKLOG) {
777-
testThreadPool.executor(ThreadPool.Names.GENERIC).execute(() -> {
778-
// re-enqueue backlogged merge task
779-
threadPoolMergeExecutorService.reEnqueueBackloggedMergeTask(mergeTask);
780-
});
781-
}
782-
return schedule;
783-
}).when(mergeTask).schedule();
774+
// avoid backlogging and re-enqueing merge tasks in this test because it makes the queue's available budget unsteady
775+
when(mergeTask.schedule()).thenReturn(randomFrom(RUN, ABORT));
784776
// let some task complete, which will NOT hold up any budget
785777
if (randomBoolean()) {
786778
// this task will NOT hold up any budget because it runs quickly (it is not blocked)

0 commit comments

Comments
 (0)