[CI] Auto commit changes from spotless

Author: elasticsearchmachine

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/ChangePointOperator.java

@@ -38,7 +38,9 @@ public class ChangePointOperator implements Operator {
 
     public static final int INPUT_VALUE_COUNT_LIMIT = 1000;
 
-    public record Factory(int metricChannel, List<Integer> partitionChannel, String sourceText, int sourceLine, int sourceColumn) implements OperatorFactory {
+    public record Factory(int metricChannel, List<Integer> partitionChannel, String sourceText, int sourceLine, int sourceColumn)
+        implements
+            OperatorFactory {
         @Override
         public Operator get(DriverContext driverContext) {
             return new ChangePointOperator(driverContext, metricChannel, partitionChannel, sourceText, sourceLine, sourceColumn);
@@ -64,7 +66,14 @@ public String describe() {
 
     // TODO: make org.elasticsearch.xpack.esql.core.tree.Source available here
     // (by modularizing esql-core) and use that instead of the individual fields.
-    public ChangePointOperator(DriverContext driverContext, int metricChannel, List<Integer> partitionChannel, String sourceText, int sourceLine, int sourceColumn) {
+    public ChangePointOperator(
+        DriverContext driverContext,
+        int metricChannel,
+        List<Integer> partitionChannel,
+        String sourceText,
+        int sourceLine,
+        int sourceColumn
+    ) {
         this.driverContext = driverContext;
         this.metricChannel = metricChannel;
         this.partitionChannel = partitionChannel;
@@ -128,7 +137,6 @@ private void createOutputPages() {
         }
         boolean tooManyValues = maxValuesCount > INPUT_VALUE_COUNT_LIMIT;
 
-
         List<MlAggsHelper.DoubleBucketValues> bucketValuesPerPartition = new ArrayList<>();
         boolean hasNulls = false;
         boolean hasMultivalued = false;
@@ -168,14 +176,14 @@ private void createOutputPages() {
                 }
             }
             // Handle last partition separately
-//        if (lastPartitionFieldValue != null) {
+            // if (lastPartitionFieldValue != null) {
             MlAggsHelper.DoubleBucketValues bucketValues = new MlAggsHelper.DoubleBucketValues(
                 null,
                 values.stream().mapToDouble(Double::doubleValue).toArray(),
                 bucketIndexes.stream().mapToInt(Integer::intValue).toArray()
             );
             bucketValuesPerPartition.add(bucketValues);
-//        }
+            // }
         }
 
         List<ChangeType> changeTypes = new ArrayList<>();
@@ -237,7 +245,9 @@ private void insertChangePoints(Iterable<ChangeType> changeTypes) {
 
             try {
                 // TODO: How to handle case when there are no change points
-                if (changeType != null && pageStartIndex <= changeType.changePoint() && changeType.changePoint() < pageStartIndex + inputPage.getPositionCount()) {
+                if (changeType != null
+                    && pageStartIndex <= changeType.changePoint()
+                    && changeType.changePoint() < pageStartIndex + inputPage.getPositionCount()) {
                     try (
                         BytesRefBlock.Builder changeTypeBlockBuilder = blockFactory.newBytesRefBlockBuilder(inputPage.getPositionCount());
                         DoubleBlock.Builder pvalueBlockBuilder = blockFactory.newDoubleBlockBuilder(inputPage.getPositionCount())
@@ -258,7 +268,7 @@ private void insertChangePoints(Iterable<ChangeType> changeTypes) {
                     changeTypeBlock = blockFactory.newConstantNullBlock(inputPage.getPositionCount());
                     changePvalueBlock = blockFactory.newConstantNullBlock(inputPage.getPositionCount());
                 }
-                outputPage = inputPage.appendBlocks(new Block[]{changeTypeBlock, changePvalueBlock});
+                outputPage = inputPage.appendBlocks(new Block[] { changeTypeBlock, changePvalueBlock });
                 if (pageStartIndex + inputPage.getPositionCount() > INPUT_VALUE_COUNT_LIMIT) {
                     outputPage = outputPage.subPage(0, INPUT_VALUE_COUNT_LIMIT - pageStartIndex);
                 }
@@ -310,7 +320,7 @@ private static String describe(int metricChannel, List<Integer> partitionChannel
             + metricChannel
             + ", partitionChannels="
             + partitionChannel.stream().map(c -> c.toString()).collect(Collectors.joining(",", "[", "]"))
-        + "]";
+            + "]";
     }
 
     private Warnings warnings(boolean onlyWarnings) {

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/operator/topn/TopNOperator.java

@@ -451,78 +451,78 @@ private Iterator<Page> toPages() {
         // TODO: optimize case where all the queues are empty
         try {
             for (var entry : inputQueues.entrySet()) {
-            Queue inputQueue = entry.getValue();
+                Queue inputQueue = entry.getValue();
 
-            list = new ArrayList<>(inputQueue.size());
-            builders = null;
-            while (inputQueue.size() > 0) {
-                list.add(inputQueue.pop());
-            }
-            Collections.reverse(list);
-
-            int p = 0;
-            int size = 0;
-            for (int i = 0; i < list.size(); i++) {
-                if (builders == null) {
-                    size = Math.min(maxPageSize, list.size() - i);
-                    builders = new ResultBuilder[elementTypes.size()];
-                    for (int b = 0; b < builders.length; b++) {
-                        builders[b] = ResultBuilder.resultBuilderFor(
-                            blockFactory,
-                            elementTypes.get(b),
-                            encoders.get(b).toUnsortable(),
-                            channelInKey(sortOrders, b),
-                            size
-                        );
-                    }
-                    p = 0;
+                list = new ArrayList<>(inputQueue.size());
+                builders = null;
+                while (inputQueue.size() > 0) {
+                    list.add(inputQueue.pop());
                 }
+                Collections.reverse(list);
+
+                int p = 0;
+                int size = 0;
+                for (int i = 0; i < list.size(); i++) {
+                    if (builders == null) {
+                        size = Math.min(maxPageSize, list.size() - i);
+                        builders = new ResultBuilder[elementTypes.size()];
+                        for (int b = 0; b < builders.length; b++) {
+                            builders[b] = ResultBuilder.resultBuilderFor(
+                                blockFactory,
+                                elementTypes.get(b),
+                                encoders.get(b).toUnsortable(),
+                                channelInKey(sortOrders, b),
+                                size
+                            );
+                        }
+                        p = 0;
+                    }
 
-                Row row = list.get(i);
-                BytesRef keys = row.keys.bytesRefView();
-                for (SortOrder so : sortOrders) {
-                    if (keys.bytes[keys.offset] == so.nul()) {
+                    Row row = list.get(i);
+                    BytesRef keys = row.keys.bytesRefView();
+                    for (SortOrder so : sortOrders) {
+                        if (keys.bytes[keys.offset] == so.nul()) {
+                            keys.offset++;
+                            keys.length--;
+                            continue;
+                        }
                         keys.offset++;
                         keys.length--;
-                        continue;
+                        builders[so.channel].decodeKey(keys);
+                    }
+                    if (keys.length != 0) {
+                        throw new IllegalArgumentException("didn't read all keys");
                     }
-                    keys.offset++;
-                    keys.length--;
-                    builders[so.channel].decodeKey(keys);
-                }
-                if (keys.length != 0) {
-                    throw new IllegalArgumentException("didn't read all keys");
-                }
-
-                BytesRef values = row.values.bytesRefView();
-                for (ResultBuilder builder : builders) {
-                    builder.decodeValue(values);
-                }
-                if (values.length != 0) {
-                    throw new IllegalArgumentException("didn't read all values");
-                }
 
-                list.set(i, null);
-                row.close();
+                    BytesRef values = row.values.bytesRefView();
+                    for (ResultBuilder builder : builders) {
+                        builder.decodeValue(values);
+                    }
+                    if (values.length != 0) {
+                        throw new IllegalArgumentException("didn't read all values");
+                    }
 
-                p++;
-                if (p == size) {
-                    Block[] blocks = new Block[builders.length];
-                    try {
-                        for (int b = 0; b < blocks.length; b++) {
-                            blocks[b] = builders[b].build();
-                        }
-                    } finally {
-                        if (blocks[blocks.length - 1] == null) {
-                            Releasables.closeExpectNoException(blocks);
+                    list.set(i, null);
+                    row.close();
+
+                    p++;
+                    if (p == size) {
+                        Block[] blocks = new Block[builders.length];
+                        try {
+                            for (int b = 0; b < blocks.length; b++) {
+                                blocks[b] = builders[b].build();
+                            }
+                        } finally {
+                            if (blocks[blocks.length - 1] == null) {
+                                Releasables.closeExpectNoException(blocks);
+                            }
                         }
+                        result.add(new Page(blocks));
+                        Releasables.closeExpectNoException(builders);
+                        builders = null;
                     }
-                    result.add(new Page(blocks));
-                    Releasables.closeExpectNoException(builders);
-                    builders = null;
                 }
-            }
-            assert builders == null;
+                assert builders == null;
             }
             success = true;
             return result.iterator();
@@ -605,7 +605,9 @@ public Status status() {
     public String toString() {
         int queueSizeSum = inputQueues.values().stream().mapToInt(Queue::size).sum();
         return "TopNOperator[count="
-            + queueSizeSum + "/" + topCount
+            + queueSizeSum
+            + "/"
+            + topCount
             + ", elementTypes="
             + elementTypes
             + ", encoders="

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ChangePointByOperatorTests.java

@@ -19,7 +19,6 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Optional;
 
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.hasSize;
@@ -30,7 +29,7 @@ public class ChangePointByOperatorTests extends OperatorTestCase {
     @Override
     protected SourceOperator simpleInput(BlockFactory blockFactory, int size) {
         // size must be in [25, 1000] for ChangePoint to function correctly and detect the step change.
-        size = 25;//Math.clamp(size, 25, 1000);
+        size = 25;// Math.clamp(size, 25, 1000);
         List<Tuple<Long, BytesRef>> data = new ArrayList<>(size);
         for (int i = 0; i < size; i++) {  // step change 0 -> 100
             data.add(Tuple.tuple(i < size / 2 ? randomLongBetween(0, 3) : randomLongBetween(100, 103), new BytesRef("prod")));
@@ -81,7 +80,7 @@ protected void assertSimpleOutput(List<Page> input, List<Page> output) {
 
     @Override
     protected Operator.OperatorFactory simple() {
-        return new ChangePointOperator.Factory(0, List.of(1), null,0, 0);
+        return new ChangePointOperator.Factory(0, List.of(1), null, 0, 0);
     }
 
     @Override

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/ChangePointOperatorTests.java

@@ -19,7 +19,6 @@
 
 import java.util.ArrayList;
 import java.util.List;
-import java.util.Optional;
 
 import static org.hamcrest.Matchers.equalTo;
 import static org.hamcrest.Matchers.hasSize;

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/operator/topn/TopNOperatorTests.java

@@ -52,7 +52,6 @@
 import java.util.LinkedHashSet;
 import java.util.List;
 import java.util.Map;
-import java.util.Optional;
 import java.util.Set;
 import java.util.function.Function;
 import java.util.stream.Collectors;

x-pack/plugin/esql/compute/test/src/main/java/org/elasticsearch/compute/test/AbstractBlockSourceOperator.java

@@ -10,7 +10,6 @@
 import org.elasticsearch.compute.data.BlockFactory;
 import org.elasticsearch.compute.data.Page;
 import org.elasticsearch.compute.operator.SourceOperator;
-import org.elasticsearch.test.ESTestCase;
 
 /**
  * An abstract source operator. Implementations of this operator produce pages with a random