Skip to content

Commit 036fed8

Browse files
committed
add output for server
1 parent 73e6379 commit 036fed8

File tree

5 files changed

+29
-13
lines changed

5 files changed

+29
-13
lines changed

build-tools/build.gradle

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,10 @@ gradlePlugin {
5151
id = 'elasticsearch.stable-esplugin'
5252
implementationClass = 'org.elasticsearch.gradle.plugin.StablePluginBuildPlugin'
5353
}
54+
testBuildInfo {
55+
id = 'elasticsearch.test-build-info'
56+
implementationClass = 'org.elasticsearch.gradle.test.TestBuildInfoPlugin'
57+
}
5458
javaRestTest {
5559
id = 'elasticsearch.java-rest-test'
5660
implementationClass = 'org.elasticsearch.gradle.test.JavaRestTestPlugin'

build-tools/src/main/java/org/elasticsearch/gradle/plugin/BasePluginBuildPlugin.java

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,10 @@ private TaskProvider<Zip> createBundleTasks(final Project project, PluginPropert
121121
task.getIsLicensed().set(providerFactory.provider(extension::isLicensed));
122122

123123
var mainSourceSet = project.getExtensions().getByType(SourceSetContainer.class).getByName(SourceSet.MAIN_SOURCE_SET_NAME);
124-
FileCollection moduleInfoFile = mainSourceSet.getOutput().getClassesDirs().getAsFileTree().matching(p -> p.include("module-info.class"));
124+
FileCollection moduleInfoFile = mainSourceSet.getOutput()
125+
.getClassesDirs()
126+
.getAsFileTree()
127+
.matching(p -> p.include("module-info.class"));
125128
task.getModuleInfoFile().setFrom(moduleInfoFile);
126129

127130
});

build-tools/src/main/java/org/elasticsearch/gradle/plugin/GenerateTestBuildInfoTask.java

Lines changed: 13 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,11 @@
2929
import java.nio.charset.StandardCharsets;
3030
import java.nio.file.Files;
3131
import java.nio.file.Path;
32-
import java.util.*;
32+
import java.util.ArrayList;
33+
import java.util.Arrays;
34+
import java.util.HashMap;
35+
import java.util.List;
36+
import java.util.Map;
3337
import java.util.jar.Attributes;
3438
import java.util.jar.JarEntry;
3539
import java.util.jar.JarFile;
@@ -52,6 +56,9 @@ public GenerateTestBuildInfoTask() {
5256
@InputFiles
5357
public abstract Property<FileCollection> getCodeLocations();
5458

59+
@Input
60+
public abstract Property<String> getOutputFileName();
61+
5562
@OutputDirectory
5663
public abstract DirectoryProperty getOutputDirectory();
5764

@@ -70,7 +77,7 @@ public void generatePropertiesFile() throws IOException {
7077
cr.accept(new ClassVisitor(Opcodes.ASM9) {
7178
@Override
7279
public ModuleVisitor visitModule(String name, int access, String version) {
73-
//getLogger().lifecycle("FOUND 0: " + name + " | " + file.getAbsolutePath());
80+
// getLogger().lifecycle("FOUND 0: " + name + " | " + file.getAbsolutePath());
7481
moduleName[0] = name;
7582
return super.visitModule(name, access, version);
7683
}
@@ -110,7 +117,7 @@ public ModuleVisitor visitModule(String name, int access, String version) {
110117
cr.accept(new ClassVisitor(Opcodes.ASM9) {
111118
@Override
112119
public ModuleVisitor visitModule(String name, int access, String version) {
113-
//getLogger().lifecycle("FOUND 1: " + name + " | " + file.getAbsolutePath());
120+
// getLogger().lifecycle("FOUND 1: " + name + " | " + file.getAbsolutePath());
114121
moduleName[0] = name;
115122
return super.visitModule(name, access, version);
116123
}
@@ -122,7 +129,7 @@ public ModuleVisitor visitModule(String name, int access, String version) {
122129
if (moduleName[0] == null) {
123130
String amn = manifest.getMainAttributes().getValue("Automatic-Module-Name");
124131
if (amn != null) {
125-
//getLogger().lifecycle("FOUND 2: " + amn + " | " + file.getAbsolutePath());
132+
// getLogger().lifecycle("FOUND 2: " + amn + " | " + file.getAbsolutePath());
126133
moduleName[0] = amn;
127134
}
128135
}
@@ -135,7 +142,7 @@ public ModuleVisitor visitModule(String name, int access, String version) {
135142
jn = jn.substring(0, matcher.start());
136143
}
137144
jn = jn.replaceAll("[^A-Za-z0-9]", ".");
138-
//getLogger().lifecycle("FOUND 3: " + jn + " | " + file.getAbsolutePath());
145+
// getLogger().lifecycle("FOUND 3: " + jn + " | " + file.getAbsolutePath());
139146
moduleName[0] = jn;
140147
}
141148
}
@@ -174,7 +181,7 @@ public ModuleVisitor visitModule(String name, int access, String version) {
174181

175182
Path outputDirectory = getOutputDirectory().get().getAsFile().toPath();
176183
Files.createDirectories(outputDirectory);
177-
Path outputFile = outputDirectory.resolve(PROPERTIES_FILENAME);
184+
Path outputFile = outputDirectory.resolve(getOutputFileName().get());
178185

179186
try (var writer = Files.newBufferedWriter(outputFile, StandardCharsets.UTF_8)) {
180187
writer.write("{\n");

build-tools/src/main/java/org/elasticsearch/gradle/plugin/PluginBuildPlugin.java

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,12 @@
1010
package org.elasticsearch.gradle.plugin;
1111

1212
import org.elasticsearch.gradle.VersionProperties;
13-
import org.elasticsearch.gradle.dependencies.CompileOnlyResolvePlugin;
1413
import org.elasticsearch.gradle.test.TestBuildInfoPlugin;
1514
import org.gradle.api.Plugin;
1615
import org.gradle.api.Project;
17-
import org.gradle.api.file.Directory;
1816
import org.gradle.api.file.RegularFile;
1917
import org.gradle.api.provider.Provider;
2018
import org.gradle.api.provider.ProviderFactory;
21-
import org.gradle.api.tasks.SourceSet;
22-
import org.gradle.api.tasks.SourceSetContainer;
2319
import org.gradle.language.jvm.tasks.ProcessResources;
2420

2521
import javax.inject.Inject;
@@ -61,6 +57,7 @@ public void apply(final Project project) {
6157
project.getTasks().withType(GenerateTestBuildInfoTask.class).named("generateTestBuildInfo").configure(task -> {
6258
var propertiesExtension = project.getExtensions().getByType(PluginPropertiesExtension.class);
6359
task.getComponentName().set(providerFactory.provider(propertiesExtension::getName));
60+
task.getOutputFileName().set("plugin-test-build-info.json");
6461
});
6562

6663
project.getTasks().withType(ProcessResources.class).named("processResources").configure(task -> {

server/build.gradle

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ apply plugin: 'elasticsearch.build'
1111
apply plugin: 'elasticsearch.publish'
1212
apply plugin: 'elasticsearch.internal-cluster-test'
1313
apply plugin: 'elasticsearch.internal-test-artifact'
14-
// TODO: apply new plugin
14+
apply plugin: 'elasticsearch.test-build-info'
1515

1616
publishing {
1717
publications {
@@ -286,4 +286,9 @@ tasks.named("licenseHeaders").configure {
286286

287287
tasks.withType(Checkstyle.class).configureEach { t -> t.getMaxHeapSize().set("2g") }
288288

289-
// TODO: add tasks.named for new task and set server as component
289+
tasks.named("generateTestBuildInfo").configure {
290+
t -> {
291+
t.getComponentName().set("server")
292+
t.getOutputFileName().set("server-test-build-info.json")
293+
}
294+
}

0 commit comments

Comments
 (0)