Skip to content

Commit 038fe2e

Browse files
authored
Span new trace context for compute group task (#125151) (#125180)
We need to create a new trace context when registering a task. There are other issues with the task group, but I need this change to enable allow_partial_results first, then follow up with other enhancements.
1 parent bb4292e commit 038fe2e

File tree

1 file changed

+7
-5
lines changed

1 file changed

+7
-5
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plugin/ComputeService.java

Lines changed: 7 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -433,11 +433,13 @@ Runnable cancelQueryOnFailure(CancellableTask task) {
433433

434434
CancellableTask createGroupTask(Task parentTask, Supplier<String> description) throws TaskCancelledException {
435435
final TaskManager taskManager = transportService.getTaskManager();
436-
return (CancellableTask) taskManager.register(
437-
"transport",
438-
"esql_compute_group",
439-
new ComputeGroupTaskRequest(parentTask.taskInfo(transportService.getLocalNode().getId(), false).taskId(), description)
440-
);
436+
try (var ignored = transportService.getThreadPool().getThreadContext().newTraceContext()) {
437+
return (CancellableTask) taskManager.register(
438+
"transport",
439+
"esql_compute_group",
440+
new ComputeGroupTaskRequest(parentTask.taskInfo(transportService.getLocalNode().getId(), false).taskId(), description)
441+
);
442+
}
441443
}
442444

443445
private static class ComputeGroupTaskRequest extends TransportRequest {

0 commit comments

Comments
 (0)