more bug

Author: limotova

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/GenerativeRestTest.java

@@ -67,7 +67,9 @@ public abstract class GenerativeRestTest extends ESRestTestCase {
         // TS-command tests
         "Invalid call to dataType on an unresolved object \\?LASTOVERTIME", // https://github.com/elastic/elasticsearch/issues/134791
         "class org.elasticsearch.compute.data..*Block cannot be cast to class org.elasticsearch.compute.data..*Block", // https://github.com/elastic/elasticsearch/issues/134793
-        "Output has changed from \\[.*\\] to \\[.*\\]" // https://github.com/elastic/elasticsearch/issues/134794
+        "Output has changed from \\[.*\\] to \\[.*\\]", // https://github.com/elastic/elasticsearch/issues/134794
+        "unsupported logical plan node \\[Join\\]", // https://github.com/elastic/elasticsearch/issues/134882
+        "To perform a lookup join with index \\[.*\\], it must be a in lookup index mode" // https://github.com/elastic/elasticsearch/issues/134882
     );
 
     public static final Set<Pattern> ALLOWED_ERROR_PATTERNS = ALLOWED_ERRORS.stream()

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/command/pipe/TimeSeriesStatsGenerator.java

@@ -48,6 +48,13 @@ public CommandDescription generate(
             return EMPTY_DESCRIPTION;
         }
 
+        // TODO: Switch back to using nonNull as possible arguments for aggregations. Using the timestamp field in both the bucket as well
+        // as as an argument in an aggregation causes all sorts of bizarre errors with confusing messages.
+        List<EsqlQueryGenerator.Column> acceptableFields = nonNull.stream()
+            .filter(c -> c.type().equals("datetime") == false && c.type().equals("date_nanos") == false)
+            .filter(c -> c.name().equals("@timestamp") == false)
+            .toList();
+
         StringBuilder cmd = new StringBuilder(" | stats ");
 
         // TODO: increase range max to 5
@@ -57,13 +64,15 @@ public CommandDescription generate(
             if (randomBoolean()) {
                 name = EsqlQueryGenerator.randomIdentifier();
             } else {
-                name = EsqlQueryGenerator.randomName(previousOutput);
+                name = EsqlQueryGenerator.randomName(acceptableFields);
                 if (name == null) {
                     name = EsqlQueryGenerator.randomIdentifier();
                 }
             }
             // generate the aggregation
-            String expression = randomBoolean() ? EsqlQueryGenerator.metricsAgg(nonNull) : EsqlQueryGenerator.agg(nonNull);
+            String expression = randomBoolean()
+                ? EsqlQueryGenerator.metricsAgg(acceptableFields)
+                : EsqlQueryGenerator.agg(acceptableFields);
             if (i > 0) {
                 cmd.append(",");
             }
@@ -75,7 +84,7 @@ public CommandDescription generate(
 
         cmd.append(" by ");
         if (randomBoolean()) {
-            var col = EsqlQueryGenerator.randomGroupableName(nonNull);
+            var col = EsqlQueryGenerator.randomGroupableName(acceptableFields);
             if (col != null) {
                 cmd.append(col + ", ");
             }