cleanup

Author: martijnvg

x-pack/plugin/downsample/src/main/java/org/elasticsearch/xpack/downsample/DownsampleShardIndexer.java

@@ -462,11 +462,11 @@ public void collect(int docId, long owningBucketOrd) throws IOException {
                     }
                     bucketsCreated++;
                 }
-                buffer.add(docId);
-                // buffer.buffer[buffer.elementsCount++] = docId;
-                // if (buffer.size() == DOCID_BUFFER_SIZE) {
-                // leafBulkCollection();
-                // }
+//                buffer.add(docId);
+                 buffer.buffer[buffer.elementsCount++] = docId;
+                 if (buffer.size() == DOCID_BUFFER_SIZE) {
+                    bulkCollection();
+                 }
             }
 
             void leafBulkCollection() throws IOException {
@@ -489,8 +489,8 @@ void leafBulkCollection() throws IOException {
                 docsProcessed += buffer.size();
                 task.setDocsProcessed(docsProcessed);
 
-                buffer.clear();
-                // buffer.elementsCount = 0;
+                // buffer.clean() also overwrites all slots with zeros
+                buffer.elementsCount = 0;
             }
         }