Fix ClassCastException in blockloader tests

Author: jordan-powers

server/src/test/java/org/elasticsearch/index/mapper/blockloader/KeywordFieldBlockLoaderTests.java

@@ -67,17 +67,6 @@ public static Object expectedValue(Map<String, Object> fieldMapping, Object valu
         return maybeFoldList(resultList);
     }
 
-    public static boolean hasDocValues(Map<String, Object> fieldMapping, boolean defaultValue) {
-        Object value = fieldMapping.getOrDefault("doc_values", defaultValue);
-        if (value instanceof Boolean b) {
-            return b;
-        } else if (value instanceof Map) {
-            return true;
-        } else {
-            throw new IllegalArgumentException("Unexpected value [" + value + "] for mapping parameter [doc_values]");
-        }
-    }
-
     private static BytesRef convert(String value, String nullValue, int ignoreAbove) {
         if (value == null) {
             if (nullValue != null) {

test/framework/src/main/java/org/elasticsearch/index/mapper/BlockLoaderTestCase.java

@@ -275,6 +275,13 @@ private void processLevel(Map<String, Object> level, String field, ArrayList<Obj
     }
 
     public static boolean hasDocValues(Map<String, Object> fieldMapping, boolean defaultValue) {
-        return (boolean) fieldMapping.getOrDefault("doc_values", defaultValue);
+        Object value = fieldMapping.getOrDefault("doc_values", defaultValue);
+        if (value instanceof Boolean b) {
+            return b;
+        } else if (value instanceof Map) {
+            return true;
+        } else {
+            throw new IllegalArgumentException("Unexpected value [" + value + "] for mapping parameter [doc_values]");
+        }
     }
 }