Change to a more descriptive details message

Author: prwhelan

x-pack/plugin/deprecation/src/main/java/org/elasticsearch/xpack/deprecation/IndexDeprecationChecker.java

@@ -104,9 +104,11 @@ private DeprecationIssue oldIndicesCheck(
                     "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                         + "#breaking_90_transform_destination_index",
                     Strings.format(
-                        "Transforms [%s] write to this index with version [%s].",
-                        String.join(", ", transforms),
-                        currentCompatibilityVersion.toReleaseVersion()
+                        "This index was created in version [%s] and will be supported as a read-only index in 9.0. The following "
+                            + "transforms will not be able to write to this index: [%s]. Refer to the migration guide to learn more "
+                            + "about how to handle your transforms destination indices.",
+                        currentCompatibilityVersion.toReleaseVersion(),
+                        String.join(", ", transforms)
                     ),
                     false,
                     Map.of("reindex_required", true, "transform_ids", transforms)
@@ -145,17 +147,19 @@ private DeprecationIssue ignoredOldIndicesCheck(
                     "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                         + "#breaking_90_transform_destination_index",
                     Strings.format(
-                        "Transforms [%s] write to this index with version [%s] and cannot be supported as read-only in 9.0",
-                        String.join(", ", transforms),
-                        currentCompatibilityVersion.toReleaseVersion()
+                        "This index was created in version [%s] and will be supported as a read-only index in 9.0. The following "
+                            + "transforms are no longer able to write to this index: [%s]. Refer to the migration guide to learn more "
+                            + "about how to handle your transforms destination indices.",
+                        currentCompatibilityVersion.toReleaseVersion(),
+                        String.join(", ", transforms)
                     ),
                     false,
                     Map.of("reindex_required", true, "transform_ids", transforms)
                 );
             } else {
                 return new DeprecationIssue(
                     DeprecationIssue.Level.WARNING,
-                    "Old index with a compatibility version < 9.0 Has Been Ignored",
+                    "Old index with a compatibility version < 9.0 has been ignored",
                     "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
                     "This read-only index has version: "
                         + currentCompatibilityVersion.toReleaseVersion()

x-pack/plugin/deprecation/src/test/java/org/elasticsearch/xpack/deprecation/IndexDeprecationCheckerTests.java

@@ -105,7 +105,11 @@ public void testOldTransformIndicesCheck() {
             "One or more Transforms write to this index with a compatibility version < 9.0",
             "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                 + "#breaking_90_transform_destination_index",
-            "Transforms [test-transform] write to this index with version [" + OLD_VERSION.toReleaseVersion() + "].",
+            "This index was created in version ["
+                + OLD_VERSION.toReleaseVersion()
+                + "] and will be supported as a read-only index in 9.0. "
+                + "The following transforms will not be able to write to this index: [test-transform]. Refer to the "
+                + "migration guide to learn more about how to handle your transforms destination indices.",
             false,
             Map.of("reindex_required", true, "transform_ids", List.of("test-transform"))
         );
@@ -128,7 +132,11 @@ public void testOldIndicesCheckWithMultipleTransforms() {
             "One or more Transforms write to this index with a compatibility version < 9.0",
             "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                 + "#breaking_90_transform_destination_index",
-            "Transforms [test-transform1, test-transform2] write to this index with version [" + OLD_VERSION.toReleaseVersion() + "].",
+            "This index was created in version ["
+                + OLD_VERSION.toReleaseVersion()
+                + "] and will be supported as a read-only index in 9.0. "
+                + "The following transforms will not be able to write to this index: [test-transform1, test-transform2]. Refer to the "
+                + "migration guide to learn more about how to handle your transforms destination indices.",
             false,
             Map.of("reindex_required", true, "transform_ids", List.of("test-transform1", "test-transform2"))
         );
@@ -155,7 +163,11 @@ public void testMultipleOldIndicesCheckWithTransforms() {
                     "One or more Transforms write to this index with a compatibility version < 9.0",
                     "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                         + "#breaking_90_transform_destination_index",
-                    "Transforms [test-transform1] write to this index with version [" + OLD_VERSION.toReleaseVersion() + "].",
+                    "This index was created in version ["
+                        + OLD_VERSION.toReleaseVersion()
+                        + "] and will be supported as a read-only index in 9.0. "
+                        + "The following transforms will not be able to write to this index: [test-transform1]. Refer to the "
+                        + "migration guide to learn more about how to handle your transforms destination indices.",
                     false,
                     Map.of("reindex_required", true, "transform_ids", List.of("test-transform1"))
                 )
@@ -167,7 +179,11 @@ public void testMultipleOldIndicesCheckWithTransforms() {
                     "One or more Transforms write to this index with a compatibility version < 9.0",
                     "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                         + "#breaking_90_transform_destination_index",
-                    "Transforms [test-transform2] write to this index with version [" + OLD_VERSION.toReleaseVersion() + "].",
+                    "This index was created in version ["
+                        + OLD_VERSION.toReleaseVersion()
+                        + "] and will be supported as a read-only index in 9.0. "
+                        + "The following transforms will not be able to write to this index: [test-transform2]. Refer to the "
+                        + "migration guide to learn more about how to handle your transforms destination indices.",
                     false,
                     Map.of("reindex_required", true, "transform_ids", List.of("test-transform2"))
                 )
@@ -267,7 +283,7 @@ public void testOldIndicesIgnoredWarningCheck() {
             .build();
         DeprecationIssue expected = new DeprecationIssue(
             DeprecationIssue.Level.WARNING,
-            "Old index with a compatibility version < 9.0 Has Been Ignored",
+            "Old index with a compatibility version < 9.0 has been ignored",
             "https://www.elastic.co/guide/en/elasticsearch/reference/master/breaking-changes-9.0.html",
             "This read-only index has version: " + OLD_VERSION.toReleaseVersion() + " and will be supported as read-only in 9.0",
             false,
@@ -299,9 +315,11 @@ public void testOldTransformIndicesIgnoredCheck() {
             "One or more Transforms write to this old index with a compatibility version < 9.0",
             "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                 + "#breaking_90_transform_destination_index",
-            "Transforms [test-transform] write to this index with version ["
+            "This index was created in version ["
                 + OLD_VERSION.toReleaseVersion()
-                + "] and cannot be supported as read-only in 9.0",
+                + "] and will be supported as a read-only index in 9.0. "
+                + "The following transforms are no longer able to write to this index: [test-transform]. Refer to the "
+                + "migration guide to learn more about how to handle your transforms destination indices.",
             false,
             Map.of("reindex_required", true, "transform_ids", List.of("test-transform"))
         );
@@ -324,9 +342,11 @@ public void testOldIndicesIgnoredCheckWithMultipleTransforms() {
             "One or more Transforms write to this old index with a compatibility version < 9.0",
             "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                 + "#breaking_90_transform_destination_index",
-            "Transforms [test-transform1, test-transform2] write to this index with version ["
+            "This index was created in version ["
                 + OLD_VERSION.toReleaseVersion()
-                + "] and cannot be supported as read-only in 9.0",
+                + "] and will be supported as a read-only index in 9.0. "
+                + "The following transforms are no longer able to write to this index: [test-transform1, test-transform2]. Refer to the "
+                + "migration guide to learn more about how to handle your transforms destination indices.",
             false,
             Map.of("reindex_required", true, "transform_ids", List.of("test-transform1", "test-transform2"))
         );
@@ -353,9 +373,11 @@ public void testMultipleOldIndicesIgnoredCheckWithTransforms() {
                     "One or more Transforms write to this old index with a compatibility version < 9.0",
                     "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                         + "#breaking_90_transform_destination_index",
-                    "Transforms [test-transform1] write to this index with version ["
+                    "This index was created in version ["
                         + OLD_VERSION.toReleaseVersion()
-                        + "] and cannot be supported as read-only in 9.0",
+                        + "] and will be supported as a read-only index in 9.0. "
+                        + "The following transforms are no longer able to write to this index: [test-transform1]. Refer to the "
+                        + "migration guide to learn more about how to handle your transforms destination indices.",
                     false,
                     Map.of("reindex_required", true, "transform_ids", List.of("test-transform1"))
                 )
@@ -367,9 +389,11 @@ public void testMultipleOldIndicesIgnoredCheckWithTransforms() {
                     "One or more Transforms write to this old index with a compatibility version < 9.0",
                     "https://www.elastic.co/guide/en/elasticsearch/reference/master/migrating-9.0.html"
                         + "#breaking_90_transform_destination_index",
-                    "Transforms [test-transform2] write to this index with version ["
+                    "This index was created in version ["
                         + OLD_VERSION.toReleaseVersion()
-                        + "] and cannot be supported as read-only in 9.0",
+                        + "] and will be supported as a read-only index in 9.0. "
+                        + "The following transforms are no longer able to write to this index: [test-transform2]. Refer to the "
+                        + "migration guide to learn more about how to handle your transforms destination indices.",
                     false,
                     Map.of("reindex_required", true, "transform_ids", List.of("test-transform2"))
                 )