ES|QL: Address PR review comments

Remove skip version from tbucket.csv-spec
Polish code in AnalyzerTests

Closes #131068

Author: leontyevdv

x-pack/plugin/esql/qa/testFixtures/src/main/resources/tbucket.csv-spec

@@ -1,6 +1,6 @@
 // TBUCKET-specific tests
 
-tbucketByTenSecondsDuration#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByTenSecondsDuration
 required_capability: tbucket
 
 FROM sample_data
@@ -18,7 +18,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T13:55:01.543Z | 2023-10-23T13:55:01.543Z | 2023-10-23T13:55:00.000Z
 ;
 
-tbucketByTenSecondsDurationAsString#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByTenSecondsDurationAsString
 required_capability: implicit_casting_string_literal_to_temporal_amount
 required_capability: tbucket
 
@@ -37,7 +37,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T13:55:01.543Z | 2023-10-23T13:55:01.543Z | 2023-10-23T13:55:00.000Z
 ;
 
-tbucketByTenMinutesDuration#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByTenMinutesDuration
 required_capability: tbucket
 
 FROM sample_data
@@ -52,7 +52,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T13:51:54.732Z | 2023-10-23T13:55:01.543Z | 2023-10-23T13:50:00.000Z
 ;
 
-tbucketByTenMinutesDurationAsString#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByTenMinutesDurationAsString
 required_capability: implicit_casting_string_literal_to_temporal_amount
 required_capability: tbucket
 
@@ -68,7 +68,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T13:51:54.732Z | 2023-10-23T13:55:01.543Z | 2023-10-23T13:50:00.000Z
 ;
 
-docsTBucketByOneHourDuration#[skip:-9.1.99,reason:new grouping function added in 9.2]
+docsTBucketByOneHourDuration
 required_capability: tbucket
 
 // tag::docsTBucketByOneHourDuration[]
@@ -85,7 +85,7 @@ min:datetime             | max:datetime             | bucket:datetime
 // end::docsTBucketByOneHourDuration-result[]
 ;
 
-docsTBucketByOneHourDurationAsString#[skip:-9.1.99,reason:new grouping function added in 9.2]
+docsTBucketByOneHourDurationAsString
 required_capability: implicit_casting_string_literal_to_temporal_amount
 required_capability: tbucket
 
@@ -103,7 +103,7 @@ min:datetime             | max:datetime             | bucket:datetime
 // end::docsTBucketByOneHourDurationAsString-result[]
 ;
 
-tbucketByOneDayDuration#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByOneDayDuration
 required_capability: tbucket
 
 FROM sample_data
@@ -115,7 +115,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T12:15:03.360Z | 2023-10-23T13:55:01.543Z | 2023-10-23T00:00:00.000Z
 ;
 
-tbucketByOneDayDurationAsString#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByOneDayDurationAsString
 required_capability: implicit_casting_string_literal_to_temporal_amount
 required_capability: tbucket
 
@@ -128,7 +128,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T12:15:03.360Z | 2023-10-23T13:55:01.543Z | 2023-10-23T00:00:00.000Z
 ;
 
-tbucketByOneWeekDuration#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByOneWeekDuration
 required_capability: tbucket
 
 FROM sample_data
@@ -140,7 +140,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T12:15:03.360Z | 2023-10-23T13:55:01.543Z | 2023-10-23T00:00:00.000Z
 ;
 
-tbucketByOneWeekDurationAsString#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByOneWeekDurationAsString
 required_capability: implicit_casting_string_literal_to_temporal_amount
 required_capability: tbucket
 
@@ -153,7 +153,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T12:15:03.360Z | 2023-10-23T13:55:01.543Z | 2023-10-23T00:00:00.000Z
 ;
 
-tbucketByOneMonthDuration#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByOneMonthDuration
 required_capability: tbucket
 
 FROM sample_data
@@ -165,7 +165,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T12:15:03.360Z | 2023-10-23T13:55:01.543Z | 2023-10-01T00:00:00.000Z
 ;
 
-tbucketByOneMonthDurationAsString#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByOneMonthDurationAsString
 required_capability: implicit_casting_string_literal_to_temporal_amount
 required_capability: tbucket
 
@@ -178,7 +178,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T12:15:03.360Z | 2023-10-23T13:55:01.543Z | 2023-10-01T00:00:00.000Z
 ;
 
-tbucketByOneYearDuration#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByOneYearDuration
 required_capability: tbucket
 
 FROM sample_data
@@ -190,7 +190,7 @@ min:datetime             | max:datetime             | bucket:datetime
 2023-10-23T12:15:03.360Z | 2023-10-23T13:55:01.543Z | 2023-01-01T00:00:00.000Z
 ;
 
-tbucketByOneYearDurationAsString#[skip:-9.1.99,reason:new grouping function added in 9.2]
+tbucketByOneYearDurationAsString
 required_capability: implicit_casting_string_literal_to_temporal_amount
 required_capability: tbucket
 

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/AnalyzerTests.java

@@ -4134,16 +4134,16 @@ public void testGroupingOverridesInInlinestats() {
     }
 
     public void testTBucketWithIntervalInStringInBothAggregationAndGrouping() {
-        var plan = analyze("""
+        LogicalPlan plan = analyze("""
             FROM sample_data
             | STATS min = MIN(@timestamp), max = MAX(@timestamp) BY bucket = TBUCKET("1 week")
             | SORT min
             """, "mapping-sample_data.json");
 
-        var limit = as(plan, Limit.class);
-        var orderBy = as(limit.child(), OrderBy.class);
-        var agg = as(orderBy.child(), Aggregate.class);
-        var aggregates = agg.aggregates();
+        Limit limit = as(plan, Limit.class);
+        OrderBy orderBy = as(limit.child(), OrderBy.class);
+        Aggregate agg = as(orderBy.child(), Aggregate.class);
+        List<? extends NamedExpression> aggregates = agg.aggregates();
         assertThat(aggregates, hasSize(3));
         Alias a = as(aggregates.get(0), Alias.class);
         assertEquals("min", a.name());