Merge branch 'main' into fix/127690

Author: JeremyDahlgren

benchmarks/src/main/java/org/elasticsearch/benchmark/vector/OSQScorerBenchmark.java

@@ -17,7 +17,7 @@
 import org.apache.lucene.util.VectorUtil;
 import org.apache.lucene.util.quantization.OptimizedScalarQuantizer;
 import org.elasticsearch.common.logging.LogConfigurator;
-import org.elasticsearch.simdvec.ES91OSQVectorsScorer;
+import org.elasticsearch.simdvec.internal.vectorization.ES91OSQVectorsScorer;
 import org.elasticsearch.simdvec.internal.vectorization.ESVectorizationProvider;
 import org.openjdk.jmh.annotations.Benchmark;
 import org.openjdk.jmh.annotations.BenchmarkMode;

docs/changelog/127988.yaml

@@ -0,0 +1,5 @@
+pr: 127988
+summary: Add emit time to hash aggregation status
+area: ES|QL
+type: enhancement
+issues: []

libs/geo/src/test/java/org/elasticsearch/geometry/utils/SpatialEnvelopeVisitorTests.java

@@ -134,7 +134,7 @@ public void testVisitGeoPointsWrapping() {
             } else {
                 // Both positive and negative x values exist, we need to decide which way to wrap the bbox
                 double unwrappedWidth = maxPosX - minNegX;
-                double wrappedWidth = (180 - minPosX) - (-180 - maxNegX);
+                double wrappedWidth = 360.0 + maxNegX - minPosX;
                 if (unwrappedWidth <= wrappedWidth) {
                     // The smaller bbox is around the front of the planet, no dateline wrapping required
                     assertRectangleResult(i + ": " + point, result, minNegX, maxPosX, maxY, minY, false);

libs/simdvec/src/main/java/org/elasticsearch/simdvec/ESVectorUtil.java

@@ -9,13 +9,11 @@
 
 package org.elasticsearch.simdvec;
 
-import org.apache.lucene.store.IndexInput;
 import org.apache.lucene.util.BitUtil;
 import org.apache.lucene.util.Constants;
 import org.elasticsearch.simdvec.internal.vectorization.ESVectorUtilSupport;
 import org.elasticsearch.simdvec.internal.vectorization.ESVectorizationProvider;
 
-import java.io.IOException;
 import java.lang.invoke.MethodHandle;
 import java.lang.invoke.MethodHandles;
 import java.lang.invoke.MethodType;
@@ -43,10 +41,6 @@ public class ESVectorUtil {
 
     private static final ESVectorUtilSupport IMPL = ESVectorizationProvider.getInstance().getVectorUtilSupport();
 
-    public static ES91OSQVectorsScorer getES91OSQVectorsScorer(IndexInput input, int dimension) throws IOException {
-        return ESVectorizationProvider.getInstance().newES91OSQVectorsScorer(input, dimension);
-    }
-
     public static long ipByteBinByte(byte[] q, byte[] d) {
         if (q.length != d.length * B_QUERY) {
             throw new IllegalArgumentException("vector dimensions incompatible: " + q.length + "!= " + B_QUERY + " x " + d.length);
@@ -217,40 +211,4 @@ public static void centerAndCalculateOSQStatsDp(float[] target, float[] centroid
         assert stats.length == 6;
         IMPL.centerAndCalculateOSQStatsDp(target, centroid, centered, stats);
     }
-
-    /**
-     * Calculates the difference between two vectors and stores the result in a third vector.
-     * @param v1 the first vector
-     * @param v2 the second vector
-     * @param result the result vector, must be the same length as the input vectors
-     */
-    public static void subtract(float[] v1, float[] v2, float[] result) {
-        if (v1.length != v2.length) {
-            throw new IllegalArgumentException("vector dimensions differ: " + v1.length + "!=" + v2.length);
-        }
-        if (result.length != v1.length) {
-            throw new IllegalArgumentException("vector dimensions differ: " + result.length + "!=" + v1.length);
-        }
-        for (int i = 0; i < v1.length; i++) {
-            result[i] = v1[i] - v2[i];
-        }
-    }
-
-    /**
-     * calculates the spill-over score for a vector and a centroid, given its residual with
-     * its actually nearest centroid
-     * @param v1 the vector
-     * @param centroid the centroid
-     * @param originalResidual the residual with the actually nearest centroid
-     * @return the spill-over score (soar)
-     */
-    public static float soarResidual(float[] v1, float[] centroid, float[] originalResidual) {
-        if (v1.length != centroid.length) {
-            throw new IllegalArgumentException("vector dimensions differ: " + v1.length + "!=" + centroid.length);
-        }
-        if (originalResidual.length != v1.length) {
-            throw new IllegalArgumentException("vector dimensions differ: " + originalResidual.length + "!=" + v1.length);
-        }
-        return IMPL.soarResidual(v1, centroid, originalResidual);
-    }
 }

libs/simdvec/src/main/java/org/elasticsearch/simdvec/internal/vectorization/DefaultESVectorUtilSupport.java

@@ -138,18 +138,6 @@ public void centerAndCalculateOSQStatsDp(float[] target, float[] centroid, float
         stats[5] = centroidDot;
     }
 
-    @Override
-    public float soarResidual(float[] v1, float[] centroid, float[] originalResidual) {
-        assert v1.length == centroid.length;
-        assert v1.length == originalResidual.length;
-        float proj = 0;
-        for (int i = 0; i < v1.length; i++) {
-            float djk = v1[i] - centroid[i];
-            proj = fma(djk, originalResidual[i], proj);
-        }
-        return proj;
-    }
-
     public static int ipByteBitImpl(byte[] q, byte[] d) {
         return ipByteBitImpl(q, d, 0);
     }

libs/simdvec/src/main/java/org/elasticsearch/simdvec/internal/vectorization/DefaultESVectorizationProvider.java

@@ -10,7 +10,6 @@
 package org.elasticsearch.simdvec.internal.vectorization;
 
 import org.apache.lucene.store.IndexInput;
-import org.elasticsearch.simdvec.ES91OSQVectorsScorer;
 
 import java.io.IOException;
 

libs/simdvec/src/main/java/org/elasticsearch/simdvec/ES91OSQVectorsScorer.java renamed to libs/simdvec/src/main/java/org/elasticsearch/simdvec/internal/vectorization/ES91OSQVectorsScorer.java

@@ -6,7 +6,7 @@
  * your election, the "Elastic License 2.0", the "GNU Affero General Public
  * License v3.0 only", or the "Server Side Public License, v 1".
  */
-package org.elasticsearch.simdvec;
+package org.elasticsearch.simdvec.internal.vectorization;
 
 import org.apache.lucene.index.VectorSimilarityFunction;
 import org.apache.lucene.store.IndexInput;

libs/simdvec/src/main/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorUtilSupport.java

@@ -28,7 +28,4 @@ public interface ESVectorUtilSupport {
     void centerAndCalculateOSQStatsEuclidean(float[] target, float[] centroid, float[] centered, float[] stats);
 
     void centerAndCalculateOSQStatsDp(float[] target, float[] centroid, float[] centered, float[] stats);
-
-    float soarResidual(float[] v1, float[] centroid, float[] originalResidual);
-
 }

libs/simdvec/src/main/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java

@@ -10,7 +10,6 @@
 package org.elasticsearch.simdvec.internal.vectorization;
 
 import org.apache.lucene.store.IndexInput;
-import org.elasticsearch.simdvec.ES91OSQVectorsScorer;
 
 import java.io.IOException;
 import java.util.Objects;

libs/simdvec/src/main21/java/org/elasticsearch/simdvec/internal/vectorization/ESVectorizationProvider.java

@@ -13,7 +13,6 @@
 import org.apache.lucene.util.Constants;
 import org.elasticsearch.logging.LogManager;
 import org.elasticsearch.logging.Logger;
-import org.elasticsearch.simdvec.ES91OSQVectorsScorer;
 
 import java.io.IOException;
 import java.util.Locale;