Duplicate tests from NetworkDirectionProcessor into NetworkDirectionutils tests

Author: MattAlp

server/src/test/java/org/elasticsearch/common/network/NetworkDirectionUtilsTests.java

@@ -0,0 +1,48 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the "Elastic License
+ * 2.0", the "GNU Affero General Public License v3.0 only", and the "Server Side
+ * Public License v 1"; you may not use this file except in compliance with, at
+ * your election, the "Elastic License 2.0", the "GNU Affero General Public
+ * License v3.0 only", or the "Server Side Public License, v 1".
+ */
+
+package org.elasticsearch.common.network;
+
+import org.elasticsearch.test.ESTestCase;
+
+import java.util.List;
+
+import static org.hamcrest.Matchers.equalTo;
+
+public class NetworkDirectionUtilsTests extends ESTestCase {
+    public void testCIDR()  {
+        testNetworkDirectionUtils("10.0.1.1", "192.168.1.2", List.of("10.0.0.0/8"), "outbound");
+        testNetworkDirectionUtils("192.168.1.2", "10.0.1.1", List.of("10.0.0.0/8"), "inbound");
+    }
+
+    public void testUnspecified()  {
+        testNetworkDirectionUtils("0.0.0.0", "0.0.0.0", List.of("unspecified"), "internal");
+        testNetworkDirectionUtils("::", "::", List.of("unspecified"), "internal");
+    }
+
+    public void testNetworkPrivate()  {
+        testNetworkDirectionUtils("192.168.1.1", "192.168.1.2", List.of("private"), "internal");
+        testNetworkDirectionUtils("10.0.1.1", "192.168.1.2", List.of("private"), "internal");
+        testNetworkDirectionUtils("192.168.1.1", "172.16.0.1", List.of("private"), "internal");
+        testNetworkDirectionUtils("192.168.1.1", "fd12:3456:789a:1::1", List.of("private"), "internal");
+    }
+
+    public void testNetworkPublic()  {
+        testNetworkDirectionUtils("192.168.1.1", "192.168.1.2", List.of("public"), "external");
+        testNetworkDirectionUtils("10.0.1.1", "192.168.1.2", List.of("public"), "external");
+        testNetworkDirectionUtils("192.168.1.1", "172.16.0.1", List.of("public"), "external");
+        testNetworkDirectionUtils("192.168.1.1", "fd12:3456:789a:1::1", List.of("public"), "external");
+    }
+
+    private void testNetworkDirectionUtils(String source, String destination, List<String> networks, String expectedDirection) {
+        boolean sourceInternal = NetworkDirectionUtils.isInternal(networks, source);
+        boolean destinationInternal = NetworkDirectionUtils.isInternal(networks, destination);
+        assertThat(expectedDirection, equalTo(NetworkDirectionUtils.getDirection(sourceInternal, destinationInternal)));
+    }
+}

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/ip/NetworkDirection.java

@@ -126,24 +126,24 @@ public EvalOperator.ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvalua
     }
 
     @Evaluator
-    static BytesRef process(@Fixed(includeInToString=false, scope=THREAD_LOCAL) BytesRef scratch, BytesRef sourceIp, BytesRef destinationIp, @Position int position, BytesRefBlock internalNetworks) {
+    static BytesRef process(@Fixed(includeInToString=false, scope=THREAD_LOCAL) BytesRef scratch, BytesRef sourceIp, BytesRef destinationIp, @Position int position, BytesRefBlock networks) {
         // Pulling the bytes out directly using InetAddress.getByAddress() requires error handling TODO
         InetAddress sourceIpAddress = InetAddresses.forString(sourceIp.utf8ToString());
         InetAddress destinationIpAddress = InetAddresses.forString(destinationIp.utf8ToString());
         boolean sourceInternal = false;
         boolean destinationInternal = false;
 
-        int valueCount = internalNetworks.getValueCount(position);
-        int first = internalNetworks.getFirstValueIndex(position);
+        int valueCount = networks.getValueCount(position);
+        int first = networks.getFirstValueIndex(position);
 
         for (int i = first; i < first + valueCount; i++) {
-            if (NetworkDirectionUtils.inNetwork(sourceIpAddress, internalNetworks.getBytesRef(i, scratch).utf8ToString())) {
+            if (NetworkDirectionUtils.inNetwork(sourceIpAddress, networks.getBytesRef(i, scratch).utf8ToString())) {
                 sourceInternal = true;
                 break;
             }
         }
         for (int i = first; i < first + valueCount; i++) {
-            if (NetworkDirectionUtils.inNetwork(destinationIpAddress, internalNetworks.getBytesRef(i, scratch).utf8ToString())) {
+            if (NetworkDirectionUtils.inNetwork(destinationIpAddress, networks.getBytesRef(i, scratch).utf8ToString())) {
                 destinationInternal = true;
                 break;
             }

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/ip/NetworkDirectionTests.java

@@ -7,15 +7,30 @@
 
 package org.elasticsearch.xpack.esql.expression.function.scalar.ip;
 
+import com.carrotsearch.randomizedtesting.annotations.Name;
+
+import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
+
+import org.apache.lucene.util.BytesRef;
+import org.elasticsearch.common.network.NetworkDirectionUtils;
+import org.elasticsearch.test.ESTestCase;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.tree.Source;
+import org.elasticsearch.xpack.esql.core.type.DataType;
 import org.elasticsearch.xpack.esql.expression.function.AbstractScalarFunctionTestCase;
+import org.elasticsearch.xpack.esql.expression.function.TestCaseSupplier;
+import org.elasticsearch.xpack.esql.type.EsqlDataTypeConverter;
 
 import java.util.List;
+import java.util.function.Supplier;
 
 public class NetworkDirectionTests extends AbstractScalarFunctionTestCase {
+    public NetworkDirectionTests(@Name("TestCase") Supplier<TestCaseSupplier.TestCase> testCaseSupplier) {
+        this.testCase = testCaseSupplier.get();
+    }
+
     @Override
     protected Expression build(Source source, List<Expression> args) {
-        return null;
+        return new NetworkDirection(source, args.get(0), args.get(1), args.get(2));
     }
 }