Explain

Author: nik9000

server/src/main/java/org/elasticsearch/index/mapper/TextFieldMapper.java

@@ -67,6 +67,7 @@
 import org.elasticsearch.index.fielddata.SourceValueFetcherSortedBinaryIndexFieldData;
 import org.elasticsearch.index.fielddata.StoredFieldSortedBinaryIndexFieldData;
 import org.elasticsearch.index.fielddata.plain.PagedBytesIndexFieldData;
+import org.elasticsearch.index.query.MatchQueryBuilder;
 import org.elasticsearch.index.query.SearchExecutionContext;
 import org.elasticsearch.index.similarity.SimilarityProvider;
 import org.elasticsearch.script.field.DelegateDocValuesField;
@@ -714,7 +715,10 @@ public static class TextFieldType extends StringFieldType {
          */
         private final KeywordFieldMapper.KeywordFieldType syntheticSourceDelegate;
 
-        // NOCOMMIT docs
+        /**
+         * Does a {@link MatchQueryBuilder} produce <strong>all</strong> documents
+         * that <strong>might</strong> have equal text to the query's value.
+         */
         private final boolean matchQueryYieldsCandidateMatchesForEquality;
 
         public TextFieldType(

x-pack/plugin/esql/compute/src/test/java/org/elasticsearch/compute/lucene/ValuesSourceReaderOperatorTests.java

@@ -1421,6 +1421,7 @@ private TextFieldMapper.TextFieldType storedTextField(String name) {
             null,
             Map.of(),
             false,
+            false,
             false
         );
     }
@@ -1435,6 +1436,7 @@ private TextFieldMapper.TextFieldType textFieldWithDelegate(String name, Keyword
             delegate,
             Map.of(),
             false,
+            false,
             false
         );
     }

x-pack/plugin/esql/qa/server/single-node/src/javaRestTest/java/org/elasticsearch/xpack/esql/qa/single_node/PushQueriesIT.java

@@ -8,11 +8,10 @@
 package org.elasticsearch.xpack.esql.qa.single_node;
 
 import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
-import com.carrotsearch.randomizedtesting.annotations.Repeat;
 import com.carrotsearch.randomizedtesting.annotations.ThreadLeakFilters;
 
-import org.elasticsearch.client.Request;
 import org.apache.lucene.analysis.standard.StandardAnalyzer;
+import org.elasticsearch.client.Request;
 import org.elasticsearch.client.Response;
 import org.elasticsearch.client.ResponseException;
 import org.elasticsearch.common.collect.Iterators;
@@ -35,7 +34,6 @@
 import java.util.Locale;
 import java.util.Map;
 import java.util.regex.Pattern;
-import java.util.stream.Stream;
 
 import static org.elasticsearch.test.ListMatcher.matchesList;
 import static org.elasticsearch.test.MapMatcher.assertMap;
@@ -53,7 +51,7 @@
 /**
  * Tests for pushing queries to lucene.
  */
-//@Repeat(iterations = 50)
+// @Repeat(iterations = 50)
 @ThreadLeakFilters(filters = TestClustersThreadFilter.class)
 public class PushQueriesIT extends ESRestTestCase {
     @ClassRule

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/optimizer/rules/physical/local/LucenePushdownPredicates.java

@@ -7,6 +7,7 @@
 
 package org.elasticsearch.xpack.esql.optimizer.rules.physical.local;
 
+import org.elasticsearch.index.query.MatchQueryBuilder;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.expression.FieldAttribute;
 import org.elasticsearch.xpack.esql.core.expression.MetadataAttribute;
@@ -47,9 +48,15 @@ public interface LucenePushdownPredicates {
      */
     boolean isIndexed(FieldAttribute attr);
 
+    /**
+     * Can the synthetic _source delegate perform {@code ==} on the provided string?
+     */
     boolean canUseEqualityOnSyntheticSourceDelegate(FieldAttribute attr, String value);
 
-    // NOCOMMIT javadoc this and above
+    /**
+     * Does a {@link MatchQueryBuilder} produce a complete list of all possible documents
+     * that <strong>might</strong> be {@code ==} to the value passed to the query.
+     */
     boolean matchQueryYieldsCandidateMatchesForEquality(FieldAttribute attr);
 
     /**

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/optimizer/LocalPhysicalPlanOptimizerTests.java

@@ -795,7 +795,7 @@ public void testOutOfRangeFilterPushdown() {
                 var query = "from test | where " + comparison;
                 Source expectedSource = new Source(1, 18, comparison);
 
-                logger.info("Query: " + query);
+                logger.info("Query: {}", query);
                 EsQueryExec actualQueryExec = doTestOutOfRangeFilterPushdown(query, allTypeMappingAnalyzer);
 
                 assertThat(actualQueryExec.query(), is(instanceOf(SingleValueQuery.Builder.class)));