Add remaining test types

Author: MattAlp

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/ip/NetworkDirection.java

@@ -12,7 +12,6 @@
 import org.elasticsearch.common.io.stream.NamedWriteableRegistry;
 import org.elasticsearch.common.io.stream.StreamInput;
 import org.elasticsearch.common.io.stream.StreamOutput;
-import org.elasticsearch.common.network.InetAddresses;
 import org.elasticsearch.common.network.NetworkDirectionUtils;
 import org.elasticsearch.compute.ann.Evaluator;
 import org.elasticsearch.compute.ann.Fixed;
@@ -160,4 +159,16 @@ static BytesRef process(@Fixed(includeInToString=false, scope=THREAD_LOCAL) Byte
     public DataType dataType() {
         return DataType.KEYWORD;
     }
+
+    public Expression sourceIpField() {
+        return sourceIpField;
+    }
+
+    public Expression destinationIpField() {
+        return destinationIpField;
+    }
+
+    public Expression internalNetworks() {
+        return internalNetworks;
+    }
 }

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/ip/NetworkDirectionErrorTests.java

@@ -0,0 +1,41 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+package org.elasticsearch.xpack.esql.expression.function.scalar.ip;
+
+import org.elasticsearch.xpack.esql.core.expression.Expression;
+import org.elasticsearch.xpack.esql.core.tree.Source;
+import org.elasticsearch.xpack.esql.core.type.DataType;
+import org.elasticsearch.xpack.esql.expression.function.ErrorsForCasesWithoutExamplesTestCase;
+import org.elasticsearch.xpack.esql.expression.function.TestCaseSupplier;
+import org.hamcrest.Matcher;
+
+import java.util.List;
+import java.util.Set;
+
+import static org.hamcrest.Matchers.equalTo;
+
+public class NetworkDirectionErrorTests extends ErrorsForCasesWithoutExamplesTestCase {
+    @Override
+    protected List<TestCaseSupplier> cases() {
+        return paramsToSuppliers(NetworkDirectionTests.parameters());
+    }
+
+    @Override
+    protected Expression build(Source source, List<Expression> args) {
+        return new NetworkDirection(source, args.get(0), args.get(1), args.get(2));
+    }
+
+    @Override
+    protected Matcher<String> expectedTypeErrorMatcher(List<Set<DataType>> validPerPosition, List<DataType> signature) {
+        return equalTo(typeErrorMessage(true, validPerPosition, signature, (v, p) -> switch (p) {
+            case 0, 1 -> "ip";
+            case 2 -> "keyword";
+            default -> "";
+        }));
+    }
+}

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/ip/NetworkDirectionSerializationTests.java

@@ -0,0 +1,41 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+package org.elasticsearch.xpack.esql.expression.function.scalar.ip;
+
+import org.elasticsearch.xpack.esql.core.expression.Expression;
+import org.elasticsearch.xpack.esql.core.tree.Source;
+import org.elasticsearch.xpack.esql.expression.AbstractExpressionSerializationTests;
+
+import java.io.IOException;
+
+public class NetworkDirectionSerializationTests extends AbstractExpressionSerializationTests<NetworkDirection> {
+
+    @Override
+    protected NetworkDirection createTestInstance() {
+        Source source = randomSource();
+        Expression sourceIpField = randomChild();
+        Expression destinationIpField = randomChild();
+        Expression internalNetworks = randomChild();
+        return new NetworkDirection(source, sourceIpField, destinationIpField, internalNetworks);
+    }
+
+    @Override
+    protected NetworkDirection mutateInstance(NetworkDirection instance) throws IOException {
+        Source source = instance.source();
+        Expression sourceIpField = instance.sourceIpField();
+        Expression destinationIpField = instance.destinationIpField();
+        Expression internalNetworks = instance.internalNetworks();
+        switch (between(0, 2)) {
+            case 0 -> sourceIpField = randomValueOtherThan(sourceIpField, AbstractExpressionSerializationTests::randomChild);
+            case 1 -> destinationIpField = randomValueOtherThan(destinationIpField, AbstractExpressionSerializationTests::randomChild);
+            case 2 -> internalNetworks = randomValueOtherThan(internalNetworks, AbstractExpressionSerializationTests::randomChild);
+        }
+
+        return new NetworkDirection(source, sourceIpField, destinationIpField, internalNetworks);
+    }
+}