Skip to content

Commit 08a25c4

Browse files
committed
Move comment to correct place
1 parent bcc88f1 commit 08a25c4

File tree

1 file changed

+2
-1
lines changed
  • x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis

1 file changed

+2
-1
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -454,6 +454,8 @@ protected LogicalPlan rule(LogicalPlan plan, AnalyzerContext context) {
454454
}
455455
final List<Attribute> childrenOutput = new ArrayList<>();
456456

457+
// Gather all the children's output in case of non-unary plans; even for unaries, we need to copy because we may mutate this to
458+
// simplify resolution of e.g. RENAME.
457459
for (LogicalPlan child : plan.children()) {
458460
var output = child.output();
459461
childrenOutput.addAll(output);
@@ -939,7 +941,6 @@ private LogicalPlan resolveKeep(Project p, List<Attribute> childOutput) {
939941
}
940942

941943
private LogicalPlan resolveDrop(Drop drop, List<Attribute> childOutput) {
942-
// Make a copy of childOutput because we may mutate this to simplify resolution of e.g. RENAME.
943944
List<NamedExpression> resolvedProjections = new ArrayList<>(childOutput);
944945

945946
for (var ne : drop.removals()) {

0 commit comments

Comments
 (0)