Skip to content

Commit 0a87d8b

Browse files
committed
Expand comment
1 parent 82d359b commit 0a87d8b

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/planner/LocalExecutionPlanner.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -768,7 +768,8 @@ private PhysicalOperation planLookupJoin(LookupJoinExec join, LocalExecutionPlan
768768

769769
private record MatchConfig(FieldAttribute.FieldName fieldName, int channel, DataType type) {
770770
private MatchConfig(FieldAttribute match, Layout.ChannelAndType input) {
771-
// Note, this handles TEXT fields with KEYWORD subfields
771+
// TODO: Using exactAttribute was supposed to handle TEXT fields with KEYWORD subfields - but we don't allow these in lookup
772+
// indices, so the call to exactAttribute looks redundant now.
772773
this(match.exactAttribute().fieldName(), input.channel(), input.type());
773774
}
774775
}

0 commit comments

Comments
 (0)