addressing remaining comments for clamps (#136511)

* addressing remaining comments for clamps

* fixup

Author: pabloem

docs/reference/query-languages/esql/_snippets/functions/examples/clamp.md

@@ -82,19 +82,45 @@ required_capability: clamp_functions
 TS k8s
 | EVAL full_clamped_cost = clamp(network.cost, 1, 20)
 | KEEP full_clamped_cost, @timestamp
-// end::clamp-max[]
+// end::clamp[]
 | SORT full_clamped_cost DESC, @timestamp | LIMIT 10;
 
-// tag::clamp-max-result[]
+// tag::clamp-result[]
 full_clamped_cost:double | @timestamp:datetime
 12.5                     | 2024-05-10T00:09:52.000Z
 12.375                   | 2024-05-10T00:01:29.000Z
 12.375                   | 2024-05-10T00:06:42.000Z
 12.375                   | 2024-05-10T00:17:12.000Z
+// end::clamp-result[]
 12.25                    | 2024-05-10T00:19:48.000Z
 12.125                   | 2024-05-10T00:00:57.000Z
 12.125                   | 2024-05-10T00:03:26.000Z
 12.125                   | 2024-05-10T00:07:19.000Z
 12.125                   | 2024-05-10T00:17:39.000Z
 12.0                     | 2024-05-10T00:08:08.000Z
 ;
+
+clamp_without_stats_using_column
+required_capability: clamp_functions
+// tag::clamp[]
+TS k8s
+| EVAL full_clamped_cost = clamp(network.cost, clamp_max(network.bytes_in, 5), network.bytes_in / 100)
+| KEEP full_clamped_cost, @timestamp
+// end::clamp[]
+| SORT full_clamped_cost DESC, @timestamp | LIMIT 10;
+
+// tag::clamp-result[]
+full_clamped_cost:double | @timestamp:datetime
+10.0                     | 2024-05-10T00:18:33.000Z
+9.0                      | 2024-05-10T00:04:49.000Z
+9.0                      | 2024-05-10T00:15:51.000Z
+9.0                      | 2024-05-10T00:17:12.000Z
+9.0                      | 2024-05-10T00:20:46.000Z
+// end::clamp-result[]
+9.0                      | 2024-05-10T00:22:54.000Z
+8.625                    | 2024-05-10T00:11:53.000Z
+8.625                    | 2024-05-10T00:17:20.000Z
+8.625                    | 2024-05-10T00:19:36.000Z
+8.375                    | 2024-05-10T00:03:26.000Z
+;
+

docs/reference/query-languages/esql/_snippets/functions/examples/clamp_max.md

@@ -88,7 +88,7 @@ protected TypeResolution resolveType() {
         }
 
         var field = children().get(0);
-        var min = children().get(1);
+        var max = children().get(1);
         var fieldDataType = field.dataType();
         TypeResolution resolution = TypeResolutions.isType(
             field,
@@ -104,8 +104,8 @@ protected TypeResolution resolveType() {
             return new TypeResolution("'field' must not be null in clamp()");
         }
         resolution = TypeResolutions.isType(
-            min,
-            t -> t.isNumeric() ? fieldDataType.isNumeric() : t.noText() == fieldDataType,
+            max,
+            t -> t.isNumeric() ? fieldDataType.isNumeric() : t.noText() == fieldDataType.noText(),
             sourceText(),
             TypeResolutions.ParamOrdinal.SECOND,
             fieldDataType.typeName()
@@ -133,11 +133,10 @@ public boolean foldable() {
 
     @Override
     public ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvaluator) {
-        // force datatype initialization
         var outputType = dataType();
 
         var max = children().get(1);
-        var maxF = outputType != max.dataType()
+        var maxF = PlannerUtils.toElementType(outputType) != PlannerUtils.toElementType(max.dataType())
             ? Cast.cast(source(), max.dataType(), outputType, toEvaluator.apply(max))
             : toEvaluator.apply(max);
 

docs/reference/query-languages/esql/kibana/definition/functions/clamp.json

@@ -105,7 +105,7 @@ protected TypeResolution resolveType() {
         }
         resolution = TypeResolutions.isType(
             min,
-            t -> t.isNumeric() ? fieldDataType.isNumeric() : t.noText() == fieldDataType,
+            t -> t.isNumeric() ? fieldDataType.isNumeric() : t.noText() == fieldDataType.noText(),
             sourceText(),
             TypeResolutions.ParamOrdinal.SECOND,
             fieldDataType.typeName()
@@ -133,11 +133,10 @@ public boolean foldable() {
 
     @Override
     public ExpressionEvaluator.Factory toEvaluator(ToEvaluator toEvaluator) {
-        // force datatype initialization
         var outputType = dataType();
 
         var min = children().get(1);
-        var minF = outputType != min.dataType()
+        var minF = PlannerUtils.toElementType(outputType) != PlannerUtils.toElementType(min.dataType())
             ? Cast.cast(source(), min.dataType(), outputType, toEvaluator.apply(min))
             : toEvaluator.apply(min);