Skip to content

Commit 0b0be87

Browse files
committed
Add TODO
1 parent 7f82b43 commit 0b0be87

File tree

2 files changed

+2
-0
lines changed

2 files changed

+2
-0
lines changed

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/blockhash/CategorizeBlockHash.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -204,6 +204,7 @@ private Block buildIntermediateBlock() {
204204
}
205205

206206
BytesRef serializeCategorizer() {
207+
// TODO: This BytesStreamOutput is not accounted for by the circuit breaker. Fix that!
207208
try (BytesStreamOutput out = new BytesStreamOutput()) {
208209
out.writeBoolean(seenNull);
209210
out.writeVInt(categorizer.getCategoryCount());

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/aggregation/blockhash/CategorizePackedValuesBlockHash.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,7 @@ public Block[] getKeys() {
134134
// keys, with the category IDs replaced by the categorizer's internal state
135135
// together with the list of category IDs.
136136
BytesRef state;
137+
// TODO: This BytesStreamOutput is not accounted for by the circuit breaker. Fix that!
137138
try (BytesStreamOutput out = new BytesStreamOutput()) {
138139
out.writeBytesRef(categorizeBlockHash.serializeCategorizer());
139140
((IntVector) keys[0].asVector()).writeTo(out);

0 commit comments

Comments
 (0)