cleanup

Author: john-wagster

server/src/main/java/org/elasticsearch/search/retriever/KnnRetrieverBuilder.java

@@ -115,8 +115,6 @@ public static KnnRetrieverBuilder fromXContent(XContentParser parser, RetrieverP
     private final RescoreVectorBuilder rescoreVectorBuilder;
     private final Float similarity;
 
-    // FIXME: add ctors like this to the other builders
-    // FIXME: from a testing standpoint should we replace this with the ctor below sometimes
     public KnnRetrieverBuilder(
         String field,
         float[] queryVector,

server/src/main/java/org/elasticsearch/search/vectors/KnnSearchBuilder.java

@@ -136,6 +136,7 @@ public static KnnSearchBuilder.Builder fromXContent(XContentParser parser) throw
      * @param queryVector the query vector
      * @param k           the final number of nearest neighbors to return as top hits
      * @param numCands    the number of nearest neighbor candidates to consider per shard
+     * @param visitPercentage percentage of the total number of vectors to visit per shard
      * @param rescoreVectorBuilder rescore vector information
      */
     public KnnSearchBuilder(
@@ -166,6 +167,7 @@ public KnnSearchBuilder(
      * @param queryVector the query vector
      * @param k           the final number of nearest neighbors to return as top hits
      * @param numCands    the number of nearest neighbor candidates to consider per shard
+     * @param visitPercentage percentage of the total number of vectors to visit per shard
      */
     public KnnSearchBuilder(
         String field,
@@ -186,6 +188,7 @@ public KnnSearchBuilder(
      * @param queryVectorBuilder the query vector builder
      * @param k                  the final number of nearest neighbors to return as top hits
      * @param numCands           the number of nearest neighbor candidates to consider per shard
+     * @param visitPercentage    percentage of the total number of vectors to visit per shard
      */
     public KnnSearchBuilder(
         String field,

server/src/main/java/org/elasticsearch/search/vectors/KnnVectorQueryBuilder.java

@@ -567,8 +567,6 @@ protected Query doToQuery(SearchExecutionContext context) throws IOException {
             }
         }
         int adjustedNumCands = numCands == null ? Math.round(Math.min(NUM_CANDS_MULTIPLICATIVE_FACTOR * k, NUM_CANDS_LIMIT)) : numCands;
-
-        // FIXME: how do the other params interact with this?
         float adjustedVisitPercentage = visitPercentage == null ? 0.0f : visitPercentage;
 
         if (fieldType == null) {