Skip to content

Commit 0da401a

Browse files
committed
Reinstate & fix testWriteLargeBlob{,Streaming}
1 parent f504e35 commit 0da401a

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

modules/repository-s3/src/main/java/org/elasticsearch/repositories/s3/S3BlobStore.java

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -566,7 +566,11 @@ static Operation parse(String s) {
566566
);
567567
}
568568

569-
private static final Predicate<String> IS_PUT_MULTIPART_OPERATION = Set.of("CreateMultipartUpload", "UploadPart")::contains;
569+
private static final Predicate<String> IS_PUT_MULTIPART_OPERATION = Set.of(
570+
"CreateMultipartUpload",
571+
"UploadPart",
572+
"CompleteMultipartUpload"
573+
)::contains;
570574

571575
boolean assertConsistentOperationName(MetricCollection metricCollection) {
572576
final var operationNameMetrics = metricCollection.metricValues(CoreMetric.OPERATION_NAME);

modules/repository-s3/src/test/java/org/elasticsearch/repositories/s3/S3BlobContainerRetriesTests.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -323,7 +323,6 @@ public void testWriteBlobWithReadTimeouts() {
323323
assertThat(exception.getCause().getCause().getMessage().toLowerCase(Locale.ROOT), containsString("read timed out"));
324324
}
325325

326-
@AwaitsFix(bugUrl = "TODO NOMERGE")
327326
public void testWriteLargeBlob() throws Exception {
328327
final boolean useTimeout = rarely();
329328
final TimeValue readTimeout = useTimeout ? TimeValue.timeValueMillis(randomIntBetween(100, 500)) : null;
@@ -425,7 +424,6 @@ public void testWriteLargeBlob() throws Exception {
425424
assertThat(countDownComplete.isCountedDown(), is(true));
426425
}
427426

428-
@AwaitsFix(bugUrl = "TODO NOMERGE")
429427
public void testWriteLargeBlobStreaming() throws Exception {
430428
final boolean useTimeout = rarely();
431429
final TimeValue readTimeout = useTimeout ? TimeValue.timeValueMillis(randomIntBetween(100, 500)) : null;

0 commit comments

Comments
 (0)