Remove disabling field names test (#116937)

The test is conditional on the old version being pre-v8, which is never true on main now

Author: thecoop

test/framework/src/main/java/org/elasticsearch/test/rest/RestTestLegacyFeatures.java

@@ -78,8 +78,6 @@ public class RestTestLegacyFeatures implements FeatureSpecification {
     @UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA)
     public static final NodeFeature NEW_DATA_STREAMS_INDEX_NAME_FORMAT = new NodeFeature("data_stream.new_index_name_format");
     @UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA)
-    public static final NodeFeature DISABLE_FIELD_NAMES_FIELD_REMOVED = new NodeFeature("disable_of_field_names_field_removed");
-    @UpdateForV9(owner = UpdateForV9.Owner.CORE_INFRA)
     public static final NodeFeature ML_NLP_SUPPORTED = new NodeFeature("ml.nlp_supported");
 
     // YAML
@@ -113,7 +111,6 @@ public Map<NodeFeature, Version> getHistoricalFeatures() {
             entry(SLM_SUPPORTED, Version.V_7_4_0),
             entry(DATA_STREAMS_SUPPORTED, Version.V_7_9_0),
             entry(NEW_DATA_STREAMS_INDEX_NAME_FORMAT, Version.V_7_11_0),
-            entry(DISABLE_FIELD_NAMES_FIELD_REMOVED, Version.V_8_0_0),
             entry(ML_NLP_SUPPORTED, Version.V_8_0_0)
         );
     }

x-pack/qa/full-cluster-restart/src/javaRestTest/java/org/elasticsearch/xpack/restart/FullClusterRestartIT.java

@@ -26,7 +26,6 @@
 import org.elasticsearch.core.UpdateForV9;
 import org.elasticsearch.rest.RestStatus;
 import org.elasticsearch.rest.action.search.RestSearchAction;
-import org.elasticsearch.test.MapMatcher;
 import org.elasticsearch.test.StreamsUtils;
 import org.elasticsearch.test.rest.ESRestTestCase;
 import org.elasticsearch.test.rest.RestTestLegacyFeatures;
@@ -53,8 +52,6 @@
 import java.util.stream.Collectors;
 
 import static org.elasticsearch.core.TimeValue.timeValueSeconds;
-import static org.elasticsearch.test.MapMatcher.assertMap;
-import static org.elasticsearch.test.MapMatcher.matchesMap;
 import static org.elasticsearch.upgrades.FullClusterRestartIT.assertNumHits;
 import static org.hamcrest.Matchers.anyOf;
 import static org.hamcrest.Matchers.containsString;
@@ -965,82 +962,6 @@ public void testDataStreams() throws Exception {
         assertNumHits("ds", 1, 1);
     }
 
-    /**
-     * Tests that a single document survives. Super basic smoke test.
-     */
-    @UpdateForV9(owner = UpdateForV9.Owner.SEARCH_FOUNDATIONS) // Can be removed
-    public void testDisableFieldNameField() throws IOException {
-        assumeFalse(
-            "can only disable field names field before 8.0",
-            oldClusterHasFeature(RestTestLegacyFeatures.DISABLE_FIELD_NAMES_FIELD_REMOVED)
-        );
-
-        String docLocation = "/nofnf/_doc/1";
-        String doc = """
-            {
-              "dv": "test",
-              "no_dv": "test"
-            }""";
-
-        if (isRunningAgainstOldCluster()) {
-            Request createIndex = new Request("PUT", "/nofnf");
-            createIndex.setJsonEntity("""
-                {
-                  "settings": {
-                    "index": {
-                      "number_of_replicas": 1
-                    }
-                  },
-                  "mappings": {
-                    "_field_names": { "enabled": false },
-                    "properties": {
-                      "dv": { "type": "keyword" },
-                      "no_dv": { "type": "keyword", "doc_values": false }
-                    }
-                  }
-                }""");
-            createIndex.setOptions(RequestOptions.DEFAULT.toBuilder().setWarningsHandler(fieldNamesFieldOk()));
-            client().performRequest(createIndex);
-
-            Request createDoc = new Request("PUT", docLocation);
-            createDoc.addParameter("refresh", "true");
-            createDoc.setJsonEntity(doc);
-            client().performRequest(createDoc);
-        }
-
-        Request getRequest = new Request("GET", docLocation);
-        assertThat(toStr(client().performRequest(getRequest)), containsString(doc));
-
-        if (isRunningAgainstOldCluster() == false) {
-            Request esql = new Request("POST", "_query");
-            esql.setJsonEntity("""
-                {
-                  "query": "FROM nofnf | LIMIT 1"
-                }""");
-            // {"columns":[{"name":"dv","type":"keyword"},{"name":"no_dv","type":"keyword"}],"values":[["test",null]]}
-            try {
-                Map<String, Object> result = entityAsMap(client().performRequest(esql));
-                MapMatcher mapMatcher = matchesMap();
-                if (result.get("took") != null) {
-                    mapMatcher = mapMatcher.entry("took", ((Integer) result.get("took")).intValue());
-                }
-                assertMap(
-                    result,
-                    mapMatcher.entry(
-                        "columns",
-                        List.of(Map.of("name", "dv", "type", "keyword"), Map.of("name", "no_dv", "type", "keyword"))
-                    ).entry("values", List.of(List.of("test", "test")))
-                );
-            } catch (ResponseException e) {
-                logger.error(
-                    "failed to query index without field name field. Existing indices:\n{}",
-                    EntityUtils.toString(client().performRequest(new Request("GET", "_cat/indices")).getEntity())
-                );
-                throw e;
-            }
-        }
-    }
-
     /**
      * Ignore the warning about the {@code _field_names} field. We intentionally
      * turn that field off sometimes. And other times old versions spuriously