Skip to content

Commit 0e48152

Browse files
authored
Esql date casting tests (#120420)
This adds appropriate ignore annotations for the date tests I added in #119772 to not run the tests against very old versions. Should be a no-op for main, but fix some tests in 8.x BWC. Still, I'd rather keep the tests in sync, so I'm applying this to main first. It's not set for auto-backport because I'll need to add the unmutes to the backport.
1 parent 14994f9 commit 0e48152

File tree

2 files changed

+5
-3
lines changed

2 files changed

+5
-3
lines changed

x-pack/plugin/esql/qa/testFixtures/src/main/resources/date.csv-spec

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1452,6 +1452,7 @@ cnt:long
14521452
;
14531453

14541454
implicit casting strings to dates for IN operator
1455+
required_capability: string_literal_auto_casting
14551456
FROM employees
14561457
| WHERE birth_date IN ("1953-04-20", "1958-10-31")
14571458
| KEEP emp_no, first_name;
@@ -1462,7 +1463,7 @@ emp_no:integer | first_name:keyword
14621463
10025 | Prasadram
14631464
;
14641465

1465-
IN operator with null in list, finds match
1466+
IN operator with null in list, finds match#[skip:-8.13.99, reason: default date formatter is changed in 8.14]
14661467

14671468
FROM employees
14681469
| EVAL x = NULL
@@ -1473,7 +1474,7 @@ birth_date:datetime | first_name:keyword
14731474
1958-02-19T00:00:00.000Z | Saniya
14741475
;
14751476

1476-
IN operator with null in list, doesn't find match
1477+
IN operator with null in list, doesn't find match#[skip:-8.13.99, reason: default date formatter is changed in 8.14]
14771478

14781479
FROM employees
14791480
| EVAL x = NULL
@@ -1483,7 +1484,7 @@ FROM employees
14831484
birth_date:datetime | first_name:keyword
14841485
;
14851486

1486-
IN operator with null in list, doesn't find match, EVAL to check value
1487+
IN operator with null in list, doesn't find match, EVAL to check value#[skip:-8.13.99, reason: default date formatter is changed in 8.14]
14871488

14881489
FROM employees
14891490
| EVAL x = NULL

x-pack/plugin/esql/qa/testFixtures/src/main/resources/date_nanos.csv-spec

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -748,6 +748,7 @@ ct:long | mo:date_nanos
748748
Bucket Date nanos by 10 minutes
749749
required_capability: date_trunc_date_nanos
750750
required_capability: date_nanos_bucket
751+
required_capability: string_literal_auto_casting
751752

752753
FROM date_nanos
753754
| WHERE millis > "2020-01-01"

0 commit comments

Comments
 (0)