PR comments

Author: mosche

server/src/main/java/org/elasticsearch/common/util/concurrent/EsThreadPoolExecutor.java

@@ -31,7 +31,10 @@ public class EsThreadPoolExecutor extends ThreadPoolExecutor {
 
     // noop probe to prevent starvation of work in the work queue due to ForceQueuePolicy
     // https://github.com/elastic/elasticsearch/issues/124667
-    static final Runnable WORKER_PROBE = () -> {};
+    static final Runnable WORKER_PROBE = new Runnable() {
+        @Override
+        public void run() {}
+    };
 
     private final ThreadContext contextHolder;
 

server/src/test/java/org/elasticsearch/common/util/concurrent/EsExecutorsTests.java

@@ -861,18 +861,10 @@ protected void doRun() {
             }
 
             for (int i = 0; i < 20; i++) {
-                logger.info("--> attempt [{}]", i);
+                logger.trace("--> attempt [{}]", i);
                 final var doneLatch = new CountDownLatch(1);
                 executor.execute(new Task(between(1, 500), doneLatch));
-                boolean success = false;
-                try {
-                    safeAwait(doneLatch, TimeValue.ONE_MINUTE);
-                    success = true;
-                } finally {
-                    if (success == false) {
-                        logger.info("fail");
-                    }
-                }
+                safeAwait(doneLatch, TimeValue.ONE_MINUTE);
             }
         } finally {
             ThreadPool.terminate(executor, 1, TimeUnit.SECONDS);