Fix license checks in function unit tests

Author: craigtaverner

docs/reference/query-languages/esql/kibana/definition/functions/st_geohex.json

@@ -843,7 +843,7 @@ public static void testFunctionLicenseChecks() throws Exception {
                 assertNotNull("License should not be null", license);
 
                 // Construct an instance of the class and then call it's licenseCheck method, and compare the results
-                Object[] args = new Object[signature.size() + 1];
+                Object[] args = new Object[ctor.getParameterCount()];
                 args[0] = Source.EMPTY;
                 for (int i = 0; i < signature.size(); i++) {
                     args[i + 1] = new Literal(Source.EMPTY, null, signature.get(i));

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/AbstractFunctionTestCase.java

@@ -13,6 +13,7 @@
 import org.elasticsearch.compute.operator.EvalOperator;
 import org.elasticsearch.geometry.Point;
 import org.elasticsearch.geometry.Rectangle;
+import org.elasticsearch.license.License;
 import org.elasticsearch.xpack.esql.core.expression.Literal;
 import org.elasticsearch.xpack.esql.core.tree.Source;
 import org.elasticsearch.xpack.esql.core.type.DataType;
@@ -40,6 +41,26 @@ protected interface TriFunction<T, U, V, R> {
         R apply(T t, U u, V v);
     }
 
+    /**
+     * All spatial grid functions have one license requirement in common, and that is that they are licensed aty PLATINUM level
+     * oif the spatial field is a shape, otherwise they are licensed at BASIC level. This is to mimic the license requirements
+     * of the spatial aggregations.
+     * @param fieldTypes (null for the function itself, otherwise a map of field named to types)
+     * @return The license requirement for the function with that type signature
+     */
+    protected static License.OperationMode licenseRequirement(List<DataType> fieldTypes) {
+        if (fieldTypes == null || fieldTypes.isEmpty()) {
+            // The function itself is not licensed, but the field types are.
+            return License.OperationMode.BASIC;
+        }
+        if (DataType.isSpatialShape(fieldTypes.getFirst())) {
+            // Only aggregations over shapes are licensed under platinum.
+            return License.OperationMode.PLATINUM;
+        }
+        // All other field types are licensed under basic.
+        return License.OperationMode.BASIC;
+    }
+
     private static String getFunctionClassName() {
         Class<?> testClass = getTestClass();
         String testClassName = testClass.getSimpleName();

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/SpatialGridFunctionTestCase.java

@@ -13,6 +13,7 @@
 import org.apache.lucene.util.BytesRef;
 import org.elasticsearch.common.geo.GeoBoundingBox;
 import org.elasticsearch.geometry.utils.Geohash;
+import org.elasticsearch.license.License;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.tree.Source;
 import org.elasticsearch.xpack.esql.core.type.DataType;
@@ -30,6 +31,14 @@ public StGeohashTests(@Name("TestCase") Supplier<TestCaseSupplier.TestCase> test
         this.testCase = testCaseSupplier.get();
     }
 
+    /**
+     * Since geo grid functions are primarily used for spatial aggregations,
+     * we use the same license requirement as the spatial aggregations.
+     */
+    public static License.OperationMode licenseRequirement(List<DataType> fieldTypes) {
+        return SpatialGridFunctionTestCase.licenseRequirement(fieldTypes);
+    }
+
     @ParametersFactory
     public static Iterable<Object[]> parameters() {
         final List<TestCaseSupplier> suppliers = new ArrayList<>();

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeohashTests.java

@@ -13,6 +13,7 @@
 import org.apache.lucene.util.BytesRef;
 import org.elasticsearch.common.geo.GeoBoundingBox;
 import org.elasticsearch.h3.H3;
+import org.elasticsearch.license.License;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.tree.Source;
 import org.elasticsearch.xpack.esql.core.type.DataType;
@@ -30,6 +31,14 @@ public StGeohexTests(@Name("TestCase") Supplier<TestCaseSupplier.TestCase> testC
         this.testCase = testCaseSupplier.get();
     }
 
+    /**
+     * Other geo grid functions use the same type-specific license requirement as the spatial aggregations, but geohex is licensed
+     * more strictly, at platinum for all field types.
+     */
+    public static License.OperationMode licenseRequirement(List<DataType> fieldTypes) {
+        return License.OperationMode.PLATINUM;
+    }
+
     @ParametersFactory
     public static Iterable<Object[]> parameters() {
         final List<TestCaseSupplier> suppliers = new ArrayList<>();

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/expression/function/scalar/spatial/StGeohexTests.java

@@ -12,6 +12,7 @@
 
 import org.apache.lucene.util.BytesRef;
 import org.elasticsearch.common.geo.GeoBoundingBox;
+import org.elasticsearch.license.License;
 import org.elasticsearch.search.aggregations.bucket.geogrid.GeoTileUtils;
 import org.elasticsearch.xpack.esql.core.expression.Expression;
 import org.elasticsearch.xpack.esql.core.tree.Source;
@@ -30,6 +31,14 @@ public StGeotileTests(@Name("TestCase") Supplier<TestCaseSupplier.TestCase> test
         this.testCase = testCaseSupplier.get();
     }
 
+    /**
+     * Since geo grid functions are primarily used for spatial aggregations,
+     * we use the same license requirement as the spatial aggregations.
+     */
+    public static License.OperationMode licenseRequirement(List<DataType> fieldTypes) {
+        return SpatialGridFunctionTestCase.licenseRequirement(fieldTypes);
+    }
+
     @ParametersFactory
     public static Iterable<Object[]> parameters() {
         final List<TestCaseSupplier> suppliers = new ArrayList<>();