Adding tests for UnifiedCompletionAction Request

Author: jonathan-buttner

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/inference/action/InferenceActionRequestTests.java

@@ -41,7 +41,6 @@ protected InferenceAction.Request createTestInstance() {
         return new InferenceAction.Request(
             randomFrom(TaskType.values()),
             randomAlphaOfLength(6),
-            // null,
             randomAlphaOfLengthOrNull(10),
             randomList(1, 5, () -> randomAlphaOfLength(8)),
             randomMap(0, 3, () -> new Tuple<>(randomAlphaOfLength(4), randomAlphaOfLength(4))),

x-pack/plugin/core/src/test/java/org/elasticsearch/xpack/core/inference/action/UnifiedCompletionActionRequestTests.java

@@ -0,0 +1,87 @@
+/*
+ * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one
+ * or more contributor license agreements. Licensed under the Elastic License
+ * 2.0; you may not use this file except in compliance with the Elastic License
+ * 2.0.
+ */
+
+package org.elasticsearch.xpack.core.inference.action;
+
+import org.elasticsearch.TransportVersion;
+import org.elasticsearch.common.io.stream.NamedWriteableRegistry;
+import org.elasticsearch.common.io.stream.Writeable;
+import org.elasticsearch.core.TimeValue;
+import org.elasticsearch.inference.TaskType;
+import org.elasticsearch.inference.UnifiedCompletionRequest;
+import org.elasticsearch.xpack.core.ml.AbstractBWCWireSerializationTestCase;
+
+import java.io.IOException;
+import java.util.List;
+
+import static org.hamcrest.Matchers.is;
+
+public class UnifiedCompletionActionRequestTests extends AbstractBWCWireSerializationTestCase<UnifiedCompletionAction.Request> {
+
+    public void testValidation_ReturnsException_When_UnifiedCompletionRequestMessage_Is_Null() {
+        var request = new UnifiedCompletionAction.Request(
+            "inference_id",
+            TaskType.COMPLETION,
+            UnifiedCompletionRequest.of(null),
+            TimeValue.timeValueSeconds(10)
+        );
+        var exception = request.validate();
+        assertThat(exception.getMessage(), is("Validation Failed: 1: Field [messages] cannot be null;"));
+    }
+
+    public void testValidation_ReturnsException_When_UnifiedCompletionRequest_Is_EmptyArray() {
+        var request = new UnifiedCompletionAction.Request(
+            "inference_id",
+            TaskType.COMPLETION,
+            UnifiedCompletionRequest.of(List.of()),
+            TimeValue.timeValueSeconds(10)
+        );
+        var exception = request.validate();
+        assertThat(exception.getMessage(), is("Validation Failed: 1: Field [messages] cannot be an empty array;"));
+    }
+
+    public void testValidation_ReturnsException_When_TaskType_IsNot_Completion() {
+        var request = new UnifiedCompletionAction.Request(
+            "inference_id",
+            TaskType.SPARSE_EMBEDDING,
+            UnifiedCompletionRequest.of(List.of(UnifiedCompletionRequestTests.randomMessage())),
+            TimeValue.timeValueSeconds(10)
+        );
+        var exception = request.validate();
+        assertThat(exception.getMessage(), is("Validation Failed: 1: Field [taskType] must be [completion];"));
+    }
+
+    @Override
+    protected UnifiedCompletionAction.Request mutateInstanceForVersion(UnifiedCompletionAction.Request instance, TransportVersion version) {
+        return instance;
+    }
+
+    @Override
+    protected Writeable.Reader<UnifiedCompletionAction.Request> instanceReader() {
+        return UnifiedCompletionAction.Request::new;
+    }
+
+    @Override
+    protected UnifiedCompletionAction.Request createTestInstance() {
+        return new UnifiedCompletionAction.Request(
+            randomAlphaOfLength(10),
+            randomFrom(TaskType.values()),
+            UnifiedCompletionRequestTests.randomUnifiedCompletionRequest(),
+            TimeValue.timeValueMillis(randomLongBetween(1, 2048))
+        );
+    }
+
+    @Override
+    protected UnifiedCompletionAction.Request mutateInstance(UnifiedCompletionAction.Request instance) throws IOException {
+        return randomValueOtherThan(instance, this::createTestInstance);
+    }
+
+    @Override
+    protected NamedWriteableRegistry getNamedWriteableRegistry() {
+        return new NamedWriteableRegistry(UnifiedCompletionRequest.getNamedWriteables());
+    }
+}