Skip to content

Commit 114db10

Browse files
committed
iter
1 parent c860ebb commit 114db10

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

server/src/main/java/org/elasticsearch/index/codec/vectors/IVFVectorsReader.java

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -283,6 +283,9 @@ public final void search(String field, float[] target, KnnCollector knnCollector
283283
long expectedDocs = 0;
284284
long actualDocs = 0;
285285
// initially we visit only the "centroids to search"
286+
// Note, numCollected is doing the bare minimum here.
287+
// TODO do we need to handle nested doc counts similarly to how we handle
288+
// filtering? E.g. keep exploring until we hit an expected number of parent documents vs. child vectors?
286289
while (centroidQueue.size() > 0 && centroidsVisited < nProbe && knnCollectorImpl.numCollected() < knnCollector.k()) {
287290
++centroidsVisited;
288291
// todo do we actually need to know the score???

0 commit comments

Comments
 (0)