Skip to content

Commit 135f00a

Browse files
authored
Enable testCommandNamesAsIdentifiers (#123249)
1 parent 236b955 commit 135f00a

File tree

1 file changed

+1
-14
lines changed

1 file changed

+1
-14
lines changed

x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/parser/ExpressionTests.java

Lines changed: 1 addition & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -208,21 +208,8 @@ public void testParenthesizedExpression() {
208208
assertThat(((UnresolvedAttribute) and.left()).name(), equalTo("a"));
209209
}
210210

211-
@AwaitsFix(bugUrl = "https://github.com/elastic/elasticsearch/issues/121950")
212-
public void testCommandNamesAsIdentifiersWithLimit() {
213-
Expression expr = whereExpression("from and limit");
214-
assertThat(expr, instanceOf(And.class));
215-
And and = (And) expr;
216-
217-
assertThat(and.left(), instanceOf(UnresolvedAttribute.class));
218-
assertThat(((UnresolvedAttribute) and.left()).name(), equalTo("from"));
219-
220-
assertThat(and.right(), instanceOf(UnresolvedAttribute.class));
221-
assertThat(((UnresolvedAttribute) and.right()).name(), equalTo("limit"));
222-
}
223-
224211
public void testCommandNamesAsIdentifiers() {
225-
for (var commandName : List.of("keep", "drop", "dissect", "eval")) {
212+
for (var commandName : List.of("dissect", "drop", "enrich", "eval", "keep", "limit", "sort")) {
226213
Expression expr = whereExpression("from and " + commandName);
227214
assertThat(expr, instanceOf(And.class));
228215
And and = (And) expr;

0 commit comments

Comments
 (0)