Test/legacy similarity settings - archive indices (#120352)

Create a test for archive indices with index mapping with  legacy similarity settings

Author: drempapis

x-pack/qa/repository-old-versions/src/test/java/org/elasticsearch/oldrepos/OldMappingsIT.java

@@ -33,6 +33,7 @@
 import org.junit.Before;
 
 import java.io.IOException;
+import java.util.ArrayList;
 import java.util.Arrays;
 import java.util.List;
 import java.util.Map;
@@ -81,11 +82,9 @@ public void setupIndex() throws IOException {
 
         String repoName = "old_mappings_repo";
         String snapshotName = "snap";
-        List<String> indices;
+        List<String> indices = new ArrayList<>(List.of("filebeat", "custom", "nested", "standard_token_filter", "similarity"));
         if (oldVersion.before(Version.fromString("6.0.0"))) {
-            indices = Arrays.asList("filebeat", "winlogbeat", "custom", "nested", "standard_token_filter");
-        } else {
-            indices = Arrays.asList("filebeat", "custom", "nested", "standard_token_filter");
+            indices.add("winlogbeat");
         }
 
         int oldEsPort = Integer.parseInt(System.getProperty("tests.es.port"));
@@ -109,6 +108,22 @@ public void setupIndex() throws IOException {
                     )
                 )
             );
+            assertOK(
+                oldEs.performRequest(
+                    createIndex(
+                        "similarity",
+                        "similarity.json",
+                        Settings.builder()
+                            .put(IndexMetadata.SETTING_NUMBER_OF_REPLICAS, 0)
+                            .put("index.similarity.custom_dfr.type", "DFR")
+                            .put("index.similarity.custom_dfr.basic_model", randomFrom(Arrays.asList("be", "d", "p")))
+                            .put("index.similarity.custom_dfr.after_effect", "no")
+                            .put("index.similarity.custom_dfr.normalization", "h2")
+                            .put("index.similarity.custom_dfr.normalization.h2.c", "3.0")
+                            .build()
+                    )
+                )
+            );
             assertOK(oldEs.performRequest(createIndex("custom", "custom.json")));
             assertOK(oldEs.performRequest(createIndex("nested", "nested.json")));
 
@@ -166,6 +181,12 @@ public void setupIndex() throws IOException {
             doc4.setJsonEntity(Strings.toString(bodyDoc4));
             assertOK(oldEs.performRequest(doc4));
 
+            Request doc5 = new Request("POST", "/" + "similarity" + "/" + "doc");
+            doc5.addParameter("refresh", "true");
+            XContentBuilder bodyDoc5 = XContentFactory.jsonBuilder().startObject().field("content", "Twin Peaks!").endObject();
+            doc5.setJsonEntity(Strings.toString(bodyDoc5));
+            assertOK(oldEs.performRequest(doc5));
+
             // register repo on old ES and take snapshot
             Request createRepoRequest = new Request("PUT", "/_snapshot/" + repoName);
             createRepoRequest.setJsonEntity(Strings.format("""
@@ -232,7 +253,15 @@ public void testMappingOk() throws IOException {
     }
 
     public void testStandardTokenFilter() throws IOException {
-        Request search = new Request("POST", "/" + "standard_token_filter" + "/_search");
+        assertMatchAll("standard_token_filter");
+    }
+
+    public void testSimilarityWithLegacySettings() throws IOException {
+        assertMatchAll("similarity");
+    }
+
+    private void assertMatchAll(String indexName) throws IOException {
+        Request search = new Request("POST", "/" + indexName + "/_search");
         XContentBuilder query = XContentBuilder.builder(XContentType.JSON.xContent())
             .startObject()
             .startObject("query")

x-pack/qa/repository-old-versions/src/test/resources/org/elasticsearch/oldrepos/similarity.json

@@ -0,0 +1,8 @@
+"_default_": {
+  "properties": {
+    "content": {
+      "type": "text",
+      "similarity": "custom_dfr"
+    }
+  }
+}