fix: exclude tests from release build

Author: salvatore-campagna

rest-api-spec/build.gradle

@@ -74,4 +74,6 @@ tasks.named("yamlRestCompatTestTransform").configure ({ task ->
   task.skipTest("index/91_metrics_no_subobjects/Metrics object indexing with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0")
   task.skipTest("index/91_metrics_no_subobjects/Root without subobjects with synthetic source", "_source.mode mapping attribute is no-op since 9.0.0")
   task.skipTest("indices.create/20_synthetic_source/synthetic_source with copy_to inside nested object", "temporary until backported")
+  task.skipTest("update/10_synthetic_source/keyword", "synthetic source recovery behind a feature flag and not enabled in release builds")
+  task.skipTest("update/10_synthetic_source/stored text", "synthetic source recovery behind a feature flag and not enabled in release builds")
 })

server/src/main/java/org/elasticsearch/index/mapper/MapperFeatures.java

@@ -11,9 +11,7 @@
 
 import org.elasticsearch.features.FeatureSpecification;
 import org.elasticsearch.features.NodeFeature;
-import org.elasticsearch.index.IndexSettings;
 
-import java.util.HashSet;
 import java.util.Set;
 
 /**
@@ -34,36 +32,25 @@ public class MapperFeatures implements FeatureSpecification {
     public static final NodeFeature SORT_FIELDS_CHECK_FOR_NESTED_OBJECT_FIX = new NodeFeature("mapper.nested.sorting_fields_check_fix");
     public static final NodeFeature DYNAMIC_HANDLING_IN_COPY_TO = new NodeFeature("mapper.copy_to.dynamic_handling");
 
-    public static final NodeFeature USE_SYNTHETIC_SOURCE_FOR_RECOVERY_BY_DEFAULT = new NodeFeature(
-        "index.recovery.synthetic_source_default"
-    );
-
-    private static final Set<NodeFeature> DEFAULT_TEST_FEATURES = Set.of(
-        RangeFieldMapper.DATE_RANGE_INDEXING_FIX,
-        IgnoredSourceFieldMapper.DONT_EXPAND_DOTS_IN_IGNORED_SOURCE,
-        SourceFieldMapper.REMOVE_SYNTHETIC_SOURCE_ONLY_VALIDATION,
-        SourceFieldMapper.SOURCE_MODE_FROM_INDEX_SETTING,
-        IgnoredSourceFieldMapper.IGNORED_SOURCE_AS_TOP_LEVEL_METADATA_ARRAY_FIELD,
-        IgnoredSourceFieldMapper.ALWAYS_STORE_OBJECT_ARRAYS_IN_NESTED_OBJECTS,
-        MapperService.LOGSDB_DEFAULT_IGNORE_DYNAMIC_BEYOND_LIMIT,
-        DocumentParser.FIX_PARSING_SUBOBJECTS_FALSE_DYNAMIC_FALSE,
-        CONSTANT_KEYWORD_SYNTHETIC_SOURCE_WRITE_FIX,
-        META_FETCH_FIELDS_ERROR_CODE_CHANGED,
-        SPARSE_VECTOR_STORE_SUPPORT,
-        COUNTED_KEYWORD_SYNTHETIC_SOURCE_NATIVE_SUPPORT,
-        SORT_FIELDS_CHECK_FOR_NESTED_OBJECT_FIX,
-        DYNAMIC_HANDLING_IN_COPY_TO,
-        SourceFieldMapper.SYNTHETIC_RECOVERY_SOURCE,
-        ObjectMapper.SUBOBJECTS_FALSE_MAPPING_UPDATE_FIX
-    );
-
     @Override
     public Set<NodeFeature> getTestFeatures() {
-        if (IndexSettings.RECOVERY_USE_SYNTHETIC_SOURCE.isEnabled()) {
-            final Set<NodeFeature> features = new HashSet<>(DEFAULT_TEST_FEATURES);
-            features.add(USE_SYNTHETIC_SOURCE_FOR_RECOVERY_BY_DEFAULT);
-            return features;
-        }
-        return DEFAULT_TEST_FEATURES;
+        return Set.of(
+            RangeFieldMapper.DATE_RANGE_INDEXING_FIX,
+            IgnoredSourceFieldMapper.DONT_EXPAND_DOTS_IN_IGNORED_SOURCE,
+            SourceFieldMapper.REMOVE_SYNTHETIC_SOURCE_ONLY_VALIDATION,
+            SourceFieldMapper.SOURCE_MODE_FROM_INDEX_SETTING,
+            IgnoredSourceFieldMapper.IGNORED_SOURCE_AS_TOP_LEVEL_METADATA_ARRAY_FIELD,
+            IgnoredSourceFieldMapper.ALWAYS_STORE_OBJECT_ARRAYS_IN_NESTED_OBJECTS,
+            MapperService.LOGSDB_DEFAULT_IGNORE_DYNAMIC_BEYOND_LIMIT,
+            DocumentParser.FIX_PARSING_SUBOBJECTS_FALSE_DYNAMIC_FALSE,
+            CONSTANT_KEYWORD_SYNTHETIC_SOURCE_WRITE_FIX,
+            META_FETCH_FIELDS_ERROR_CODE_CHANGED,
+            SPARSE_VECTOR_STORE_SUPPORT,
+            COUNTED_KEYWORD_SYNTHETIC_SOURCE_NATIVE_SUPPORT,
+            SORT_FIELDS_CHECK_FOR_NESTED_OBJECT_FIX,
+            DYNAMIC_HANDLING_IN_COPY_TO,
+            SourceFieldMapper.SYNTHETIC_RECOVERY_SOURCE,
+            ObjectMapper.SUBOBJECTS_FALSE_MAPPING_UPDATE_FIX
+        );
     }
 }

x-pack/plugin/logsdb/build.gradle

@@ -43,4 +43,12 @@ tasks.named('yamlRestTest') {
   usesDefaultDistribution()
 }
 
+tasks.named("yamlRestTest") {
+  if (buildParams.isSnapshotBuild() == false) {
+    systemProperty 'tests.rest.blacklist', [
+      "resources/rest-api-spec/test/60_synthetic_source_recovery.yml"
+    ].join(',')
+  }
+}
+