OptionalDouble can sometimes produce nulls

joshua-adams-1 · joshua-adams-1 · commit 154d6d103196 · 2025-07-18T09:36:13.000+01:00
diff --git a/server/src/test/java/org/elasticsearch/cluster/routing/allocation/allocator/NodeBalanceStatsTests.java b/server/src/test/java/org/elasticsearch/cluster/routing/allocation/allocator/NodeBalanceStatsTests.java
@@ -108,7 +108,6 @@ public void testSerializationWithTransportVersionNodeWeightsAddedToNodeBalanceSt
         assertNotEquals(UNKNOWN, deserialized.nodeId());
         assertNotEquals(List.of(), deserialized.roles());
         assertNotEquals(UNDESIRED_SHARD_ALLOCATION_DEFAULT_VALUE, deserialized.undesiredShardAllocations());
-        assertNotNull(deserialized.nodeWeight());
     }
 
     public void testToXContentWithoutHumanReadableNames() throws IOException {

Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,6 @@ public void testSerializationWithTransportVersionNodeWeightsAddedToNodeBalanceSt`
`108`	`108`	`assertNotEquals(UNKNOWN, deserialized.nodeId());`
`109`	`109`	`assertNotEquals(List.of(), deserialized.roles());`
`110`	`110`	`assertNotEquals(UNDESIRED_SHARD_ALLOCATION_DEFAULT_VALUE, deserialized.undesiredShardAllocations());`
`111`		`- assertNotNull(deserialized.nodeWeight());`
`112`	`111`	`}`
`113`	`112`
`114`	`113`	`public void testToXContentWithoutHumanReadableNames() throws IOException {`