Clean up TODO comments

Already moved to meta issue

Author: alex-spies

x-pack/plugin/esql/src/main/antlr/EsqlBaseParser.g4

@@ -151,8 +151,6 @@ aggField
     ;
 
 qualifiedName
-    // TODO: Test all kind of valid/invalid qualifier strings and make sure they make sense. Same for patterns below.
-    // TODO: Account for qualifiers in parameters.
     : {this.isDevVersion()}? qualifier=UNQUOTED_IDENTIFIER name=unqualifiedName
     | name=unqualifiedName
     ;
@@ -162,9 +160,6 @@ unqualifiedName
     ;
 
 qualifiedNamePattern
-    // TODO: super duper restrict what's allowed in the qualifier, e.g. no dots, no wildcards, no QUOTES etc.
-    // Can't easily do that via the lexer rules, as whatever token we use for the qualifier also needs to be a valid
-    // token for the unqualifiedNamePattern.
     : {this.isDevVersion()}? qualifier=ID_PATTERN name=unqualifiedNamePattern
     | name=unqualifiedNamePattern
     ;

x-pack/plugin/esql/src/main/antlr/parser/Join.g4

@@ -13,8 +13,6 @@ joinCommand
 joinTarget
     // Cannot use UNQUOTED_IDENTIFIER for the qualifier because the lexer will confuse it with an UNQUOTED_SOURCE; would
     // require pushing a mode to the lexer to disambiguate.
-    // TODO: UNQUOTED_SOURCE should be restricted further (no keywords, only simple chars) - and we should have reserved
-    // characters for internal usage, and it must be a subset of UNQUOTED_IDENTIFIER.
     : {this.isDevVersion()}? index=indexPattern AS? qualifier=UNQUOTED_SOURCE
     | index=indexPattern
     ;

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/parser/ExpressionBuilder.java

@@ -273,7 +273,6 @@ public UnresolvedAttribute visitQualifiedName(EsqlBaseParser.QualifiedNameContex
     }
 
     public UnresolvedAttribute visitQualifiedName(EsqlBaseParser.QualifiedNameContext ctx, UnresolvedAttribute defaultValue) {
-        // TODO: Disallow qualifier + param (for now)
         if (ctx == null) {
             return defaultValue;
         }
@@ -331,7 +330,6 @@ protected NamedExpression visitQualifiedNamePattern(
 
     @Override
     public NamedExpression visitQualifiedNamePattern(EsqlBaseParser.QualifiedNamePatternContext qualifiedCtx) {
-        // TODO: Disallow qualifier + param (for now)
         if (qualifiedCtx == null) {
             return null;
         }
@@ -498,7 +496,6 @@ public NamedExpression visitQualifiedNamePattern(EsqlBaseParser.QualifiedNamePat
             result = new UnresolvedAttribute(src, qualifier, Strings.collectionToDelimitedString(objects, ""), null);
 
             if (qualifier != null && qualifier.contains(WILDCARD)) {
-                // TODO: much more rigorous check for unallowed characters in the qualifier
                 throw qualifiersUnsupportedInPatterns(src, ((UnresolvedAttribute) result).qualifiedName());
             }
         }