Remove unused v7-only APIs (#114733)

Removes several REST endpoints that only existed in the now-inaccessible
v7-compatible mode.

Author: DaveCTurner

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestAddVotingConfigExclusionAction.java

@@ -13,7 +13,6 @@
 import org.elasticsearch.action.admin.cluster.configuration.TransportAddVotingConfigExclusionsAction;
 import org.elasticsearch.client.internal.node.NodeClient;
 import org.elasticsearch.common.Strings;
-import org.elasticsearch.core.RestApiVersion;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.rest.BaseRestHandler;
 import org.elasticsearch.rest.RestRequest;
@@ -28,23 +27,14 @@
 public class RestAddVotingConfigExclusionAction extends BaseRestHandler {
     private static final TimeValue DEFAULT_TIMEOUT = TimeValue.timeValueSeconds(30L);
 
-    private static final String DEPRECATION_MESSAGE = "POST /_cluster/voting_config_exclusions/{node_name} "
-        + "has been removed. You must use POST /_cluster/voting_config_exclusions?node_ids=... "
-        + "or POST /_cluster/voting_config_exclusions?node_names=... instead.";
-
     @Override
     public String getName() {
         return "add_voting_config_exclusions_action";
     }
 
     @Override
     public List<Route> routes() {
-        return List.of(
-            new Route(POST, "/_cluster/voting_config_exclusions"),
-            Route.builder(POST, "/_cluster/voting_config_exclusions/{node_name}")
-                .deprecated(DEPRECATION_MESSAGE, RestApiVersion.V_7)
-                .build()
-        );
+        return List.of(new Route(POST, "/_cluster/voting_config_exclusions"));
     }
 
     @Override
@@ -66,10 +56,6 @@ static AddVotingConfigExclusionsRequest resolveVotingConfigExclusionsRequest(fin
         String nodeIds = null;
         String nodeNames = null;
 
-        if (request.getRestApiVersion() == RestApiVersion.V_7 && request.hasParam("node_name")) {
-            throw new IllegalArgumentException("[node_name] has been removed, you must set [node_names] or [node_ids]");
-        }
-
         if (request.hasParam("node_ids")) {
             nodeIds = request.param("node_ids");
         }

server/src/main/java/org/elasticsearch/rest/action/admin/cluster/RestNodesHotThreadsAction.java

@@ -14,7 +14,6 @@
 import org.elasticsearch.action.admin.cluster.node.hotthreads.TransportNodesHotThreadsAction;
 import org.elasticsearch.client.internal.node.NodeClient;
 import org.elasticsearch.common.Strings;
-import org.elasticsearch.core.RestApiVersion;
 import org.elasticsearch.monitor.jvm.HotThreads;
 import org.elasticsearch.rest.BaseRestHandler;
 import org.elasticsearch.rest.RestRequest;
@@ -26,7 +25,6 @@
 
 import java.io.IOException;
 import java.util.List;
-import java.util.Locale;
 
 import static org.elasticsearch.rest.ChunkedRestResponseBodyPart.fromTextChunks;
 import static org.elasticsearch.rest.RestRequest.Method.GET;
@@ -36,64 +34,9 @@
 @ServerlessScope(Scope.INTERNAL)
 public class RestNodesHotThreadsAction extends BaseRestHandler {
 
-    private static final String formatDeprecatedMessageWithoutNodeID = "[%s] is a deprecated endpoint. "
-        + "Please use [/_nodes/hot_threads] instead.";
-    private static final String formatDeprecatedMessageWithNodeID = "[%s] is a deprecated endpoint. "
-        + "Please use [/_nodes/{nodeId}/hot_threads] instead.";
-    private static final String DEPRECATED_MESSAGE_CLUSTER_NODES_HOT_THREADS = String.format(
-        Locale.ROOT,
-        formatDeprecatedMessageWithoutNodeID,
-        "/_cluster/nodes/hot_threads"
-    );
-    private static final String DEPRECATED_MESSAGE_CLUSTER_NODES_NODEID_HOT_THREADS = String.format(
-        Locale.ROOT,
-        formatDeprecatedMessageWithNodeID,
-        "/_cluster/nodes/{nodeId}/hot_threads"
-    );
-    private static final String DEPRECATED_MESSAGE_CLUSTER_NODES_HOTTHREADS = String.format(
-        Locale.ROOT,
-        formatDeprecatedMessageWithoutNodeID,
-        "/_cluster/nodes/hotthreads"
-    );
-    private static final String DEPRECATED_MESSAGE_CLUSTER_NODES_NODEID_HOTTHREADS = String.format(
-        Locale.ROOT,
-        formatDeprecatedMessageWithNodeID,
-        "/_cluster/nodes/{nodeId}/hotthreads"
-    );
-    private static final String DEPRECATED_MESSAGE_NODES_HOTTHREADS = String.format(
-        Locale.ROOT,
-        formatDeprecatedMessageWithoutNodeID,
-        "/_nodes/hotthreads"
-    );
-    private static final String DEPRECATED_MESSAGE_NODES_NODEID_HOTTHREADS = String.format(
-        Locale.ROOT,
-        formatDeprecatedMessageWithNodeID,
-        "/_nodes/{nodeId}/hotthreads"
-    );
-
     @Override
     public List<Route> routes() {
-        return List.of(
-            new Route(GET, "/_nodes/hot_threads"),
-            new Route(GET, "/_nodes/{nodeId}/hot_threads"),
-
-            Route.builder(GET, "/_cluster/nodes/hot_threads")
-                .deprecated(DEPRECATED_MESSAGE_CLUSTER_NODES_HOT_THREADS, RestApiVersion.V_7)
-                .build(),
-            Route.builder(GET, "/_cluster/nodes/{nodeId}/hot_threads")
-                .deprecated(DEPRECATED_MESSAGE_CLUSTER_NODES_NODEID_HOT_THREADS, RestApiVersion.V_7)
-                .build(),
-            Route.builder(GET, "/_cluster/nodes/hotthreads")
-                .deprecated(DEPRECATED_MESSAGE_CLUSTER_NODES_HOTTHREADS, RestApiVersion.V_7)
-                .build(),
-            Route.builder(GET, "/_cluster/nodes/{nodeId}/hotthreads")
-                .deprecated(DEPRECATED_MESSAGE_CLUSTER_NODES_NODEID_HOTTHREADS, RestApiVersion.V_7)
-                .build(),
-            Route.builder(GET, "/_nodes/hotthreads").deprecated(DEPRECATED_MESSAGE_NODES_HOTTHREADS, RestApiVersion.V_7).build(),
-            Route.builder(GET, "/_nodes/{nodeId}/hotthreads")
-                .deprecated(DEPRECATED_MESSAGE_NODES_NODEID_HOTTHREADS, RestApiVersion.V_7)
-                .build()
-        );
+        return List.of(new Route(GET, "/_nodes/hot_threads"), new Route(GET, "/_nodes/{nodeId}/hot_threads"));
     }
 
     @Override