Skip to content

Commit 16b9960

Browse files
[Docs] Ensure breaking-changes tag exists for empty and existing breaking changes (#94911)
* Ensure breaking-changes tag exists for both cases This was previously added so that it only worked when there were no breaking changes, but should be for the case of breaking changes also * Revert "Ensure breaking-changes tag exists for both cases" This reverts commit f8cb87a. * Ensure breaking-changes tag exists for both cases This was previously added so that it only worked when there were no breaking changes, but should be for the case of breaking changes also * Improved wording
1 parent c2ce4f8 commit 16b9960

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

build-tools-internal/src/main/resources/templates/breaking-changes.asciidoc

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -26,6 +26,12 @@ Before upgrading to ${majorDotMinor}, review these changes and take the describe
2626
to mitigate the impact.
2727

2828
<%
29+
if (breakingByNotabilityByArea.getOrDefault(true, []).isEmpty()) { %>
30+
// tag::notable-breaking-changes[]
31+
There are no notable breaking changes in {es} ${majorDotMinor}.
32+
// end::notable-breaking-changes[]
33+
But there are some less critical breaking changes.
34+
<% }
2935
[true, false].each { isNotable ->
3036
def breakingByArea = breakingByNotabilityByArea.getOrDefault(isNotable, [])
3137
if (breakingByArea.isEmpty() == false) {

0 commit comments

Comments
 (0)