address pr comments

Author: efd6

docs/changelog/128540.yaml

@@ -1,6 +1,7 @@
 pr: 128540
 summary: Preserve integer-exact representation of numbers and allow conversion of
-  floating point values to integers
+  floating point values to integers in the `convert` ingest processor
 area: Ingest Node
 type: enhancement
-issues: []
+issues:
+  - 128160

modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/ConvertProcessor.java

@@ -156,20 +156,18 @@ public static Type fromString(String processorTag, String propertyName, String t
         }
 
         private static boolean isExactIntegerFloat(Object value) {
-            final float ABS_MAX_EXACT_FLOAT = (float) 0x1p24 - 1;
             if (value instanceof Float == false) {
                 return false;
             }
-            float v = ((Float) value).floatValue();
+            float v = (Float) value;
             return v == (long) v && -ABS_MAX_EXACT_FLOAT <= v && v <= ABS_MAX_EXACT_FLOAT;
         }
 
         private static boolean isExactIntegerDouble(Object value) {
-            final double ABS_MAX_EXACT_DOUBLE = 0x1p53 - 1;
             if (value instanceof Double == false) {
                 return false;
             }
-            double v = ((Double) value).doubleValue();
+            double v = (Double) value;
             return v == (long) v && -ABS_MAX_EXACT_DOUBLE <= v && v <= ABS_MAX_EXACT_DOUBLE;
         }
     }
@@ -181,6 +179,9 @@ private static boolean isExactIntegerDouble(Object value) {
     private final Type convertType;
     private final boolean ignoreMissing;
 
+    private final float ABS_MAX_EXACT_FLOAT = 0x1p24f - 1;
+    private final double ABS_MAX_EXACT_DOUBLE = 0x1p53 - 1;
+
     ConvertProcessor(String tag, String description, String field, String targetField, Type convertType, boolean ignoreMissing) {
         super(tag, description);
         this.field = field;