Skip to content

Commit 18968ba

Browse files
[ML] Fixing leaked reference in CCM tests (#137839)
* Fixing leaked reference * Unmuting tests
1 parent 9a9bf3a commit 18968ba

File tree

2 files changed

+2
-15
lines changed

2 files changed

+2
-15
lines changed

muted-tests.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -459,9 +459,6 @@ tests:
459459
method: testSimilarityWithOneDimVector {functionName=v_cosine
460460
similarityFunction=org.elasticsearch.xpack.esql.expression.function.vector.CosineSimilarity$1@5b068087 elementType=byte}
461461
issue: https://github.com/elastic/elasticsearch/issues/137778
462-
- class: org.elasticsearch.xpack.inference.integration.CCMPersistentStorageServiceIT
463-
method: testDelete_RemovesCCMConfiguration
464-
issue: https://github.com/elastic/elasticsearch/issues/137786
465462
- class: org.elasticsearch.upgrades.WildcardRollingUpgradeIT
466463
method: testIndexing {upgradedNodes=0}
467464
issue: https://github.com/elastic/elasticsearch/issues/137793
@@ -474,12 +471,6 @@ tests:
474471
- class: org.elasticsearch.upgrades.TextRollingUpgradeIT
475472
method: testIndexing {upgradedNodes=1}
476473
issue: https://github.com/elastic/elasticsearch/issues/137796
477-
- class: org.elasticsearch.xpack.inference.integration.CCMPersistentStorageServiceIT
478-
method: testDelete_DoesNotThrow_WhenTheConfigurationDoesNotExist
479-
issue: https://github.com/elastic/elasticsearch/issues/137797
480-
- class: org.elasticsearch.xpack.inference.integration.CCMServiceIT
481-
method: testIsEnabled_ReturnsTrue_WhenCCMConfigurationIsPresent
482-
issue: https://github.com/elastic/elasticsearch/issues/137798
483474
- class: org.elasticsearch.xpack.esql.vector.VectorSimilarityFunctionsIT
484475
method: testSimilarityWithOneDimVector {functionName=v_cosine
485476
similarityFunction=org.elasticsearch.xpack.esql.expression.function.vector.CosineSimilarity$1@3300f4fd elementType=byte}

x-pack/plugin/inference/src/internalClusterTest/java/org/elasticsearch/xpack/inference/integration/CCMSingleNodeIT.java

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,7 @@
2727
import java.util.Collection;
2828
import java.util.Objects;
2929

30+
import static org.elasticsearch.test.hamcrest.ElasticsearchAssertions.assertHitCount;
3031
import static org.elasticsearch.xpack.inference.services.elastic.ccm.CCMPersistentStorageService.CCM_DOC_ID;
3132
import static org.hamcrest.Matchers.containsString;
3233
import static org.hamcrest.Matchers.is;
@@ -77,12 +78,7 @@ public void testStore_OverwritesConfiguration_WhenItAlreadyExists() {
7778
assertStoreCCMConfiguration();
7879
assertStoreCCMConfiguration("new_secret");
7980

80-
var results = client().prepareSearch(CCMIndex.INDEX_PATTERN)
81-
.setQuery(QueryBuilders.idsQuery().addIds(CCM_DOC_ID))
82-
.execute()
83-
.actionGet(TimeValue.THIRTY_SECONDS);
84-
85-
assertThat(results.getHits().getHits().length, is(1));
81+
assertHitCount(client().prepareSearch(CCMIndex.INDEX_PATTERN).setQuery(QueryBuilders.idsQuery().addIds(CCM_DOC_ID)), 1);
8682
}
8783

8884
public void testGet_ThrowsResourceNotFoundException_WhenCCMIndexDoesNotExist() {

0 commit comments

Comments
 (0)