[8.2] Fix Enrich*IT test failures (#87317) (#87349)

* Fix Enrich*IT test failures (#87317)

Fix EnrichIT, EnrichSecurityIT and EnrichAdvancedSecurityIT test failures
caused by a warning being emitted during auto creation of 'my-index' index.
The warning has nothing to do with the index being created, but the monitor
index being created at the same time (in same cluster state update) triggers
a warning and that leaks to the index response in this test, which causes
test failures.

Closes #83366
Relates to #85506

* fixed compile error

Author: martijnvg

x-pack/plugin/enrich/qa/common/src/main/java/org/elasticsearch/test/enrich/CommonEnrichRestTestCase.java

@@ -137,6 +137,14 @@ private void setupGenericLifecycleTest(String field, String type, String value)
         assertOK(client().performRequest(putPipelineRequest));
         cleanupPipelineAfterTest("my_pipeline");
 
+        // Create index before indexing, so that we avoid a warning from being emitted that can fail this test.
+        // (If during auto index creation, the creation of my-index index happens together with monitoring index then
+        // a 'starts with a dot '.', in the next major version' warning from creating monitor index is also returned
+        // in the index response, because both indices were created in the same cluster state update.)
+        // (This workaround, specifically using create index api to pre-create the my-index index ensures that this
+        // index is created in isolation and warnings of other indices that may be created will not be returned)
+        // (Go to elastic/elasticsearch#85506 for more details)
+        createIndex("my-index", Settings.EMPTY);
         // Index document using pipeline with enrich processor:
         indexRequest = new Request("PUT", "/my-index/_doc/1");
         indexRequest.addParameter("pipeline", "my_pipeline");