Skip to content

Commit 19b1d40

Browse files
committed
Use parameters instead of random
1 parent 1ec7452 commit 19b1d40

File tree

2 files changed

+14
-2
lines changed

2 files changed

+14
-2
lines changed

docs/changelog/135778.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
pr: 135778
2-
summary: Add on-disk rescoring to disk BBQ
2+
summary: "Add `on_disk_rescore: true` option to disk BBQ to rescore vectors on-disk without loading into memory"
33
area: Vector Search
44
type: feature
55
issues: []

server/src/internalClusterTest/java/org/elasticsearch/index/store/DirectIOIT.java

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,8 @@
99

1010
package org.elasticsearch.index.store;
1111

12+
import com.carrotsearch.randomizedtesting.annotations.ParametersFactory;
13+
1214
import org.apache.logging.log4j.Level;
1315
import org.apache.lucene.misc.store.DirectIODirectory;
1416
import org.apache.lucene.store.Directory;
@@ -67,14 +69,24 @@ protected boolean useDirectIO(String name, IOContext context, OptionalLong fileL
6769
};
6870
}
6971

72+
private final String type;
73+
74+
@ParametersFactory
75+
public static Iterable<Object[]> parameters() {
76+
return List.<Object[]>of(new Object[] { "bbq_disk" });
77+
}
78+
79+
public DirectIOIT(String type) {
80+
this.type = type;
81+
}
82+
7083
@Override
7184
protected Collection<Class<? extends Plugin>> nodePlugins() {
7285
return List.of(InternalSettingsPlugin.class);
7386
}
7487

7588
private String indexVectors(boolean directIO) {
7689
String indexName = "test-vectors-" + directIO;
77-
String type = randomFrom("bbq_disk");
7890
assertAcked(
7991
prepareCreate(indexName).setSettings(Settings.builder().put(InternalSettingsPlugin.USE_COMPOUND_FILE.getKey(), false))
8092
.setMapping(Strings.format("""

0 commit comments

Comments
 (0)