Remove SizeValue (#134871)

In principle this utility class lets us format potentially-large numbers
nicely in API responses, but in practice it is wholly unused for that
purpose. Nor is it used to accept user input (e.g. setting values) that
could potentially be large. In the few places it appears in the codebase
we can just use `Long` instead.

Author: DaveCTurner

modules/kibana/src/internalClusterTest/java/org/elasticsearch/kibana/KibanaThreadPoolIT.java

@@ -233,7 +233,7 @@ private static void blockThreadPool(String threadPoolName, ThreadPool threadPool
     private static void fillThreadPoolQueues(String threadPoolName, ThreadPool threadPool) {
         ThreadPool.Info info = threadPool.info(threadPoolName);
 
-        for (int i = 0; i < info.getQueueSize().singles(); i++) {
+        for (int i = 0; i < info.getQueueSize(); i++) {
             try {
                 threadPool.executor(threadPoolName).execute(() -> {});
             } catch (EsRejectedExecutionException e) {

server/src/internalClusterTest/java/org/elasticsearch/action/bulk/IncrementalBulkIT.java

@@ -558,7 +558,7 @@ public boolean isForceExecution() {
     }
 
     private static void fillWriteCoordinationQueue(ThreadPool threadPool) {
-        final var queueSize = Math.toIntExact(threadPool.info(ThreadPool.Names.WRITE_COORDINATION).getQueueSize().singles());
+        final var queueSize = Math.toIntExact(threadPool.info(ThreadPool.Names.WRITE_COORDINATION).getQueueSize());
         final var queueFilled = new AtomicBoolean(false);
         final var queueFillingTask = new AbstractRunnable() {
             @Override

server/src/main/java/org/elasticsearch/common/unit/SizeValue.java

@@ -14,7 +14,6 @@
 import org.elasticsearch.common.collect.Iterators;
 import org.elasticsearch.common.regex.Regex;
 import org.elasticsearch.common.unit.ByteSizeValue;
-import org.elasticsearch.common.unit.SizeValue;
 import org.elasticsearch.common.util.set.Sets;
 import org.elasticsearch.core.Booleans;
 import org.elasticsearch.core.TimeValue;
@@ -370,24 +369,6 @@ private static String renderValue(RestRequest request, Object value) {
                 return v.toString();
             }
         }
-        if (value instanceof SizeValue v) {
-            String resolution = request.param("size");
-            if ("".equals(resolution)) {
-                return Long.toString(v.singles());
-            } else if ("k".equals(resolution)) {
-                return Long.toString(v.kilo());
-            } else if ("m".equals(resolution)) {
-                return Long.toString(v.mega());
-            } else if ("g".equals(resolution)) {
-                return Long.toString(v.giga());
-            } else if ("t".equals(resolution)) {
-                return Long.toString(v.tera());
-            } else if ("p".equals(resolution)) {
-                return Long.toString(v.peta());
-            } else {
-                return v.toString();
-            }
-        }
         if (value instanceof TimeValue v) {
             String resolution = request.param("time");
             if ("nanos".equals(resolution)) {

server/src/main/java/org/elasticsearch/rest/action/cat/RestTable.java

@@ -207,9 +207,7 @@ private Table buildTable(RestRequest req, ClusterStateResponse state, NodesInfoR
                 Integer size = null;
 
                 if (poolInfo != null) {
-                    if (poolInfo.getQueueSize() != null) {
-                        maxQueueSize = poolInfo.getQueueSize().singles();
-                    }
+                    maxQueueSize = poolInfo.getQueueSize();
                     if (poolInfo.getKeepAlive() != null) {
                         keepAlive = poolInfo.getKeepAlive();
                     }

server/src/main/java/org/elasticsearch/rest/action/cat/RestThreadPoolAction.java

@@ -11,7 +11,6 @@
 
 import org.elasticsearch.common.settings.Setting;
 import org.elasticsearch.common.settings.Settings;
-import org.elasticsearch.common.unit.SizeValue;
 import org.elasticsearch.common.util.concurrent.EsExecutors;
 import org.elasticsearch.common.util.concurrent.EsExecutors.TaskTrackingConfig;
 import org.elasticsearch.common.util.concurrent.ThreadContext;
@@ -160,7 +159,7 @@ ThreadPool.ExecutorHolder build(final FixedExecutorSettings settings, final Thre
             size,
             size,
             null,
-            queueSize < 0 ? null : new SizeValue(queueSize)
+            queueSize < 0 ? null : (long) queueSize
         );
         return new ThreadPool.ExecutorHolder(executor, info);
     }

server/src/main/java/org/elasticsearch/threadpool/FixedExecutorBuilder.java

@@ -19,7 +19,6 @@
 import org.elasticsearch.common.time.TimeProvider;
 import org.elasticsearch.common.unit.ByteSizeUnit;
 import org.elasticsearch.common.unit.ByteSizeValue;
-import org.elasticsearch.common.unit.SizeValue;
 import org.elasticsearch.common.util.concurrent.EsExecutors;
 import org.elasticsearch.common.util.concurrent.EsRejectedExecutionException;
 import org.elasticsearch.common.util.concurrent.EsRejectedExecutionHandler;
@@ -934,7 +933,7 @@ public static class Info implements Writeable, ToXContentFragment {
         private final int min;
         private final int max;
         private final TimeValue keepAlive;
-        private final SizeValue queueSize;
+        private final Long queueSize;
 
         public Info(String name, ThreadPoolType type) {
             this(name, type, -1);
@@ -944,7 +943,7 @@ public Info(String name, ThreadPoolType type, int size) {
             this(name, type, size, size, null, null);
         }
 
-        public Info(String name, ThreadPoolType type, int min, int max, @Nullable TimeValue keepAlive, @Nullable SizeValue queueSize) {
+        public Info(String name, ThreadPoolType type, int min, int max, @Nullable TimeValue keepAlive, @Nullable Long queueSize) {
             this.name = name;
             this.type = type;
             this.min = min;
@@ -959,7 +958,7 @@ public Info(StreamInput in) throws IOException {
             min = in.readInt();
             max = in.readInt();
             keepAlive = in.readOptionalTimeValue();
-            queueSize = in.readOptionalWriteable(SizeValue::new);
+            queueSize = in.readOptionalVLong();
         }
 
         @Override
@@ -969,7 +968,7 @@ public void writeTo(StreamOutput out) throws IOException {
             out.writeInt(min);
             out.writeInt(max);
             out.writeOptionalTimeValue(keepAlive);
-            out.writeOptionalWriteable(queueSize);
+            out.writeOptionalVLong(queueSize);
         }
 
         public String getName() {
@@ -994,7 +993,7 @@ public TimeValue getKeepAlive() {
         }
 
         @Nullable
-        public SizeValue getQueueSize() {
+        public Long getQueueSize() {
             return this.queueSize;
         }
 
@@ -1018,7 +1017,7 @@ public XContentBuilder toXContent(XContentBuilder builder, Params params) throws
             if (queueSize == null) {
                 builder.field("queue_size", -1);
             } else {
-                builder.field("queue_size", queueSize.singles());
+                builder.field("queue_size", queueSize);
             }
             builder.endObject();
             return builder;