Skip to content

Commit 1b7f02f

Browse files
committed
Merge remote-tracking branch 'carlosdelest/feature/esql-knn-function-minimal-support' into feature/esql-knn-function-minimal-support
# Conflicts: # x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/vector/Knn.java
2 parents e92c92b + e7736be commit 1b7f02f

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/plugin/KnnFunctionIT.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,8 @@ public void testKnnDefaults() {
4848
assertEquals(i, row.getFirst());
4949
@SuppressWarnings("unchecked")
5050
// Vectors should be the same
51-
List<Double> floats = (List<Double>)row.get(1);
52-
for(int j = 0; j < floats.size(); j++) {
51+
List<Double> floats = (List<Double>) row.get(1);
52+
for (int j = 0; j < floats.size(); j++) {
5353
assertEquals(floats.get(j).floatValue(), indexedVectors.get(i).get(j), 0f);
5454
}
5555
var score = (Double) row.get(2);

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/planner/PlannerUtils.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -301,8 +301,8 @@ public static ElementType toElementType(DataType dataType, MappedFieldType.Field
301301
case PARTIAL_AGG, AGGREGATE_METRIC_DOUBLE -> ElementType.COMPOSITE;
302302
// Can't throw IAE as this is used to estimate row size
303303
case DENSE_VECTOR -> ElementType.NULL;
304-
case SHORT, BYTE, DATE_PERIOD, TIME_DURATION, OBJECT, FLOAT, HALF_FLOAT, SCALED_FLOAT ->
305-
throw EsqlIllegalArgumentException.illegalDataType(dataType);
304+
case SHORT, BYTE, DATE_PERIOD, TIME_DURATION, OBJECT, FLOAT, HALF_FLOAT, SCALED_FLOAT -> throw EsqlIllegalArgumentException
305+
.illegalDataType(dataType);
306306
};
307307
}
308308

0 commit comments

Comments
 (0)