Conserve precious characters

Author: joegallo

modules/ingest-common/src/main/java/org/elasticsearch/ingest/common/DateProcessor.java

@@ -103,8 +103,8 @@ private static Locale newLocale(String locale) {
     }
 
     @Override
-    public IngestDocument execute(IngestDocument ingestDocument) {
-        Object obj = ingestDocument.getFieldValue(field, Object.class);
+    public IngestDocument execute(IngestDocument document) {
+        Object obj = document.getFieldValue(field, Object.class);
         String value = null;
         if (obj != null) {
             // Don't use Objects.toString(...) here, because null gets changed to "null" which may confuse some date parsers
@@ -115,7 +115,7 @@ public IngestDocument execute(IngestDocument ingestDocument) {
         // extract the timezone and locale to use for date parsing
         final ZoneId documentTimezone;
         final Locale documentLocale;
-        final Map<String, Object> sourceAndMetadata = ingestDocument.getSourceAndMetadata();
+        final Map<String, Object> sourceAndMetadata = document.getSourceAndMetadata();
         try {
             documentTimezone = newDateTimeZone(timezone == null ? null : timezone.newInstance(sourceAndMetadata).execute());
             documentLocale = newLocale(locale == null ? null : locale.newInstance(sourceAndMetadata).execute());
@@ -139,8 +139,8 @@ public IngestDocument execute(IngestDocument ingestDocument) {
             throw new IllegalArgumentException("unable to parse date [" + value + "]", lastException);
         }
 
-        ingestDocument.setFieldValue(targetField, formatter.format(dateTime));
-        return ingestDocument;
+        document.setFieldValue(targetField, formatter.format(dateTime));
+        return document;
     }
 
     @Override
@@ -182,39 +182,33 @@ public Factory(ScriptService scriptService) {
 
         public DateProcessor create(
             Map<String, Processor.Factory> registry,
-            String processorTag,
+            String tag,
             String description,
             Map<String, Object> config,
             ProjectId projectId
         ) throws Exception {
-            String field = ConfigurationUtils.readStringProperty(TYPE, processorTag, config, "field");
-            String targetField = ConfigurationUtils.readStringProperty(TYPE, processorTag, config, "target_field", DEFAULT_TARGET_FIELD);
-            String timezoneString = ConfigurationUtils.readOptionalStringProperty(TYPE, processorTag, config, "timezone");
+            String field = ConfigurationUtils.readStringProperty(TYPE, tag, config, "field");
+            String targetField = ConfigurationUtils.readStringProperty(TYPE, tag, config, "target_field", DEFAULT_TARGET_FIELD);
+            String timezoneString = ConfigurationUtils.readOptionalStringProperty(TYPE, tag, config, "timezone");
             TemplateScript.Factory compiledTimezoneTemplate = null;
             if (timezoneString != null) {
-                compiledTimezoneTemplate = ConfigurationUtils.compileTemplate(
-                    TYPE,
-                    processorTag,
-                    "timezone",
-                    timezoneString,
-                    scriptService
-                );
+                compiledTimezoneTemplate = ConfigurationUtils.compileTemplate(TYPE, tag, "timezone", timezoneString, scriptService);
             }
-            String localeString = ConfigurationUtils.readOptionalStringProperty(TYPE, processorTag, config, "locale");
+            String localeString = ConfigurationUtils.readOptionalStringProperty(TYPE, tag, config, "locale");
             TemplateScript.Factory compiledLocaleTemplate = null;
             if (localeString != null) {
-                compiledLocaleTemplate = ConfigurationUtils.compileTemplate(TYPE, processorTag, "locale", localeString, scriptService);
+                compiledLocaleTemplate = ConfigurationUtils.compileTemplate(TYPE, tag, "locale", localeString, scriptService);
             }
-            List<String> formats = ConfigurationUtils.readList(TYPE, processorTag, config, "formats");
-            String outputFormat = ConfigurationUtils.readStringProperty(TYPE, processorTag, config, "output_format", DEFAULT_OUTPUT_FORMAT);
+            List<String> formats = ConfigurationUtils.readList(TYPE, tag, config, "formats");
+            String outputFormat = ConfigurationUtils.readStringProperty(TYPE, tag, config, "output_format", DEFAULT_OUTPUT_FORMAT);
             try {
                 DateFormatter.forPattern(outputFormat);
             } catch (Exception e) {
                 throw new IllegalArgumentException("invalid output format [" + outputFormat + "]", e);
             }
 
             return new DateProcessor(
-                processorTag,
+                tag,
                 description,
                 compiledTimezoneTemplate,
                 compiledLocaleTemplate,