Skip to content

Commit 1c1f258

Browse files
committed
text should have phrase query for dynamic mappings
1 parent 9990ca7 commit 1c1f258

File tree

1 file changed

+12
-16
lines changed

1 file changed

+12
-16
lines changed

test/framework/src/main/java/org/elasticsearch/datageneration/queries/LeafQueryGenerator.java

Lines changed: 12 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,14 @@ static LeafQueryGenerator buildForType(String type) {
4646

4747
class KeywordQueryGenerator implements LeafQueryGenerator {
4848
public List<QueryBuilder> generate(Map<String, Object> fieldMapping, String path, Object value) {
49-
if (fieldMapping == null) {
50-
return List.of(QueryBuilders.termQuery(path, value));
49+
if (fieldMapping != null) {
50+
boolean isIndexed = (Boolean) fieldMapping.getOrDefault("index", true);
51+
boolean hasDocValues = (Boolean) fieldMapping.getOrDefault("doc_values", true);
52+
if (isIndexed == false && hasDocValues == false) {
53+
return List.of();
54+
}
5155
}
52-
53-
boolean isIndexed = (Boolean) fieldMapping.getOrDefault("index", true);
54-
boolean hasDocValues = (Boolean) fieldMapping.getOrDefault("doc_values", true);
55-
if (isIndexed || hasDocValues) {
56-
return List.of(QueryBuilders.termQuery(path, value));
57-
}
58-
return List.of();
56+
return List.of(QueryBuilders.termQuery(path, value));
5957
}
6058
}
6159

@@ -71,13 +69,11 @@ public List<QueryBuilder> generate(Map<String, Object> fieldMapping, String path
7169

7270
class TextQueryGenerator implements LeafQueryGenerator {
7371
public List<QueryBuilder> generate(Map<String, Object> fieldMapping, String path, Object value) {
74-
if (fieldMapping == null) {
75-
return List.of(QueryBuilders.termQuery(path, value));
76-
}
77-
78-
boolean isIndexed = (Boolean) fieldMapping.getOrDefault("index", true);
79-
if (isIndexed == false) {
80-
return List.of();
72+
if (fieldMapping != null) {
73+
boolean isIndexed = (Boolean) fieldMapping.getOrDefault("index", true);
74+
if (isIndexed == false) {
75+
return List.of();
76+
}
8177
}
8278

8379
var results = new ArrayList<QueryBuilder>();

0 commit comments

Comments
 (0)