Skip to content

Commit 1c45991

Browse files
committed
Improve docs
1 parent 4d39c4a commit 1c45991

File tree

7 files changed

+36
-4
lines changed

7 files changed

+36
-4
lines changed

docs/reference/query-languages/esql/_snippets/functions/description/day_name.md

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/examples/day_name.md

Lines changed: 10 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/_snippets/functions/layout/day_name.md

Lines changed: 3 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/kibana/definition/functions/day_name.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

docs/reference/query-languages/esql/kibana/docs/functions/day_name.md

Lines changed: 6 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

x-pack/plugin/esql/qa/testFixtures/src/main/resources/date.csv-spec

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1837,6 +1837,17 @@ y:date | c:long
18371837
1987-08-01T00:00:00.000Z | 2
18381838
;
18391839

1840+
dayNameRowTest
1841+
required_capability: day_name_function
1842+
// tag::docsDayName[]
1843+
ROW dt = to_datetime("1953-09-02T00:00:00.000Z")
1844+
| EVAL weekday = DAY_NAME(dt);
1845+
// end::docsDayName[]
1846+
1847+
dt:date | weekday:keyword
1848+
1953-09-02T00:00:00.000Z | Wednesday
1849+
;
1850+
18401851
dayNameSimple
18411852
required_capability: day_name_function
18421853
from employees

x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/expression/function/scalar/date/DayName.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ public class DayName extends EsqlConfigurationFunction {
4242

4343
private final Expression field;
4444

45-
@FunctionInfo(returnType = "keyword", description = "Returns the name of the weekday for date.",
45+
@FunctionInfo(returnType = "keyword", description = "Returns the name of the weekday for date based on the configured Locale.",
4646
examples = @Example(file = "date", tag = "docsDayName")
4747
)
4848
public DayName(

0 commit comments

Comments
 (0)