Skip to content

Commit 1c661e1

Browse files
authored
Merge branch 'main' into unmute/HttpExporterTests
2 parents aa0dbb1 + 0b06d9f commit 1c661e1

File tree

4 files changed

+11
-15
lines changed

4 files changed

+11
-15
lines changed

libs/x-content/src/main/java/org/elasticsearch/xcontent/AbstractObjectParser.java

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@
1010
package org.elasticsearch.xcontent;
1111

1212
import org.elasticsearch.core.CheckedFunction;
13+
import org.elasticsearch.core.UpdateForV10;
1314
import org.elasticsearch.xcontent.ObjectParser.NamedObjectParser;
1415
import org.elasticsearch.xcontent.ObjectParser.ValueType;
1516

@@ -230,11 +231,13 @@ public void declareDoubleOrNull(BiConsumer<Value, Double> consumer, double nullV
230231
);
231232
}
232233

234+
@UpdateForV10(owner = UpdateForV10.Owner.CORE_INFRA) // https://github.com/elastic/elasticsearch/issues/130797
233235
public void declareLong(BiConsumer<Value, Long> consumer, ParseField field) {
234236
// Using a method reference here angers some compilers
235237
declareField(consumer, p -> p.longValue(), field, ValueType.LONG);
236238
}
237239

240+
@UpdateForV10(owner = UpdateForV10.Owner.CORE_INFRA) // https://github.com/elastic/elasticsearch/issues/130797
238241
public void declareLongOrNull(BiConsumer<Value, Long> consumer, long nullValue, ParseField field) {
239242
// Using a method reference here angers some compilers
240243
declareField(
@@ -245,6 +248,7 @@ public void declareLongOrNull(BiConsumer<Value, Long> consumer, long nullValue,
245248
);
246249
}
247250

251+
@UpdateForV10(owner = UpdateForV10.Owner.CORE_INFRA) // https://github.com/elastic/elasticsearch/issues/130797
248252
public void declareInt(BiConsumer<Value, Integer> consumer, ParseField field) {
249253
// Using a method reference here angers some compilers
250254
declareField(consumer, p -> p.intValue(), field, ValueType.INT);
@@ -253,6 +257,7 @@ public void declareInt(BiConsumer<Value, Integer> consumer, ParseField field) {
253257
/**
254258
* Declare an integer field that parses explicit {@code null}s in the json to a default value.
255259
*/
260+
@UpdateForV10(owner = UpdateForV10.Owner.CORE_INFRA) // https://github.com/elastic/elasticsearch/issues/130797
256261
public void declareIntOrNull(BiConsumer<Value, Integer> consumer, int nullValue, ParseField field) {
257262
declareField(
258263
consumer,
@@ -320,10 +325,12 @@ public void declareFloatArray(BiConsumer<Value, List<Float>> consumer, ParseFiel
320325
declareFieldArray(consumer, (p, c) -> p.floatValue(), field, ValueType.FLOAT_ARRAY);
321326
}
322327

328+
@UpdateForV10(owner = UpdateForV10.Owner.CORE_INFRA) // https://github.com/elastic/elasticsearch/issues/130797
323329
public void declareLongArray(BiConsumer<Value, List<Long>> consumer, ParseField field) {
324330
declareFieldArray(consumer, (p, c) -> p.longValue(), field, ValueType.LONG_ARRAY);
325331
}
326332

333+
@UpdateForV10(owner = UpdateForV10.Owner.CORE_INFRA) // https://github.com/elastic/elasticsearch/issues/130797
327334
public void declareIntArray(BiConsumer<Value, List<Integer>> consumer, ParseField field) {
328335
declareFieldArray(consumer, (p, c) -> p.intValue(), field, ValueType.INT_ARRAY);
329336
}

muted-tests.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -461,9 +461,6 @@ tests:
461461
- class: org.elasticsearch.upgrades.MlJobSnapshotUpgradeIT
462462
method: testSnapshotUpgrader
463463
issue: https://github.com/elastic/elasticsearch/issues/98560
464-
- class: org.elasticsearch.upgrades.QueryableBuiltInRolesUpgradeIT
465-
method: testBuiltInRolesSyncedOnClusterUpgrade
466-
issue: https://github.com/elastic/elasticsearch/issues/129534
467464
- class: org.elasticsearch.search.query.VectorIT
468465
method: testFilteredQueryStrategy
469466
issue: https://github.com/elastic/elasticsearch/issues/129517
@@ -540,12 +537,6 @@ tests:
540537
- class: org.elasticsearch.xpack.esql.action.CrossClusterAsyncQueryStopIT
541538
method: testStopQueryLocal
542539
issue: https://github.com/elastic/elasticsearch/issues/121672
543-
- class: org.elasticsearch.xpack.esql.qa.multi_node.GenerativeIT
544-
method: test
545-
issue: https://github.com/elastic/elasticsearch/issues/130067
546-
- class: org.elasticsearch.xpack.esql.qa.single_node.GenerativeIT
547-
method: test
548-
issue: https://github.com/elastic/elasticsearch/issues/130067
549540
- class: org.elasticsearch.xpack.esql.action.EsqlRemoteErrorWrapIT
550541
method: testThatRemoteErrorsAreWrapped
551542
issue: https://github.com/elastic/elasticsearch/issues/130794

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/EsqlQueryGenerator.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -107,10 +107,6 @@ public static List<CsvTestsDataLoader.EnrichConfig> policiesOnKeyword(List<CsvTe
107107
return policies.stream().filter(x -> Set.of("languages_policy").contains(x.policyName())).toList();
108108
}
109109

110-
public static String randomNonVector(List<Column> previousOutput) {
111-
return randomName(previousOutput.stream().filter(x -> x.type().contains("vector") == false).toList());
112-
}
113-
114110
public static String randomName(List<Column> previousOutput) {
115111
String result = randomRawName(previousOutput);
116112
if (result == null) {
@@ -292,7 +288,9 @@ public static boolean fieldCanBeUsed(Column field) {
292288
// https://github.com/elastic/elasticsearch/issues/121741
293289
field.name().equals("<all-fields-projected>")
294290
// this is a known pathological case, no need to test it for now
295-
|| field.name().equals("<no-fields>")) == false;
291+
|| field.name().equals("<no-fields>")
292+
// no dense vectors for now, they are not supported in most commands
293+
|| field.type().contains("vector")) == false;
296294
}
297295

298296
public static String unquote(String colName) {

x-pack/plugin/esql/qa/server/src/main/java/org/elasticsearch/xpack/esql/qa/rest/generative/command/pipe/MvExpandGenerator.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,7 @@ public CommandDescription generate(
2525
List<EsqlQueryGenerator.Column> previousOutput,
2626
QuerySchema schema
2727
) {
28-
String toExpand = EsqlQueryGenerator.randomNonVector(previousOutput);
28+
String toExpand = EsqlQueryGenerator.randomName(previousOutput);
2929
if (toExpand == null) {
3030
return EMPTY_DESCRIPTION; // no columns to expand
3131
}

0 commit comments

Comments
 (0)