Remove matchAppender

Author: kderusso

x-pack/plugin/esql/compute/src/main/java/org/elasticsearch/compute/lucene/LuceneQueryEvaluator.java

@@ -266,7 +266,6 @@ Block scoreDense(T scoreBuilder, int min, int max, int positionCount) throws IOE
                     scoreBuilder,
                     ctx,
                     LuceneQueryEvaluator.this::appendNoMatch,
-                    (builder, scorer1, docId, ctc, query) -> LuceneQueryEvaluator.this.appendMatch(builder, scorer1),
                     weight.getQuery()
                 )
             ) {
@@ -322,11 +321,6 @@ private void scoreSingleDocWithScorer(T builder, int doc) throws IOException {
         }
     }
 
-    @FunctionalInterface
-    public interface MatchAppender<T, U, E extends Exception> {
-        void accept(T t, U u, int docId, LeafReaderContext leafReaderContext, Query query) throws E;
-    }
-
     /**
      * Collects matching information for dense range of doc ids. This assumes that
      * doc ids are sent to {@link LeafCollector#collect(int)} in ascending order
@@ -337,27 +331,17 @@ static class DenseCollector<U extends Block.Builder> implements LeafCollector, R
         private final int max;
         private final LeafReaderContext leafReaderContext;
         private final Consumer<U> appendNoMatch;
-        private final MatchAppender<U, Scorable, IOException> appendMatch;
         private final Query query;
 
         private Scorable scorer;
         int next;
 
-        DenseCollector(
-            int min,
-            int max,
-            U scoreBuilder,
-            LeafReaderContext leafReaderContext,
-            Consumer<U> appendNoMatch,
-            MatchAppender<U, Scorable, IOException> appendMatch,
-            Query query
-        ) {
+        DenseCollector(int min, int max, U scoreBuilder, LeafReaderContext leafReaderContext, Consumer<U> appendNoMatch, Query query) {
             this.scoreBuilder = scoreBuilder;
             this.max = max;
             next = min;
             this.leafReaderContext = leafReaderContext;
             this.appendNoMatch = appendNoMatch;
-            this.appendMatch = appendMatch;
             this.query = query;
         }
 
@@ -371,7 +355,6 @@ public void collect(int doc) throws IOException {
             while (next++ < doc) {
                 appendNoMatch.accept(scoreBuilder);
             }
-            appendMatch.accept(scoreBuilder, scorer, doc, leafReaderContext, query);
         }
 
         public Block build() {