Removed type from Pinned retriever - build successful

Author: mridula-s109

x-pack/plugin/search-business-rules/src/main/java/org/elasticsearch/xpack/searchbusinessrules/retriever/PinnedRetrieverBuilder.java

@@ -81,13 +81,11 @@ public static PinnedRetrieverBuilder fromXContent(XContentParser parser, Retriev
 
     final List<String> ids;
     final List<SpecifiedDocument> docs;
-    String type;
 
     public PinnedRetrieverBuilder(List<String> ids, List<SpecifiedDocument> docs, RetrieverBuilder retrieverBuilder, int rankWindowSize) {
         super(new ArrayList<>(), rankWindowSize);
         this.ids = ids != null ? ids : new ArrayList<>();
         this.docs = docs != null ? docs : new ArrayList<>();
-        this.type = NAME;
         addChild(new PinnedRetrieverBuilderWrapper(retrieverBuilder));
     }
 
@@ -102,14 +100,12 @@ public PinnedRetrieverBuilder(
         super(retrieverSource, rankWindowSize);
         this.ids = ids;
         this.docs = docs;
-        this.type = NAME;
         this.retrieverName = retrieverName;
         this.preFilterQueryBuilders = preFilterQueryBuilders;
     }
 
     public PinnedRetrieverBuilder(StreamInput in) throws IOException {
         super(new ArrayList<>(), in.readInt());
-        this.type = in.readString();
         if (in.getTransportVersion().onOrAfter(TransportVersions.PINNED_RETRIEVER)) {
             this.ids = in.readOptionalStringCollectionAsList();
             this.docs = in.readBoolean() ? in.readCollectionAsList(SpecifiedDocument::new) : new ArrayList<>();
@@ -154,7 +150,6 @@ protected SearchSourceBuilder finalizeSourceBuilder(SearchSourceBuilder source)
 
     @Override
     public void doToXContent(XContentBuilder builder, Params params) throws IOException {
-        builder.field("type", type);
         builder.field("rank_window_size", rankWindowSize());
         if (ids.isEmpty() == false) {
             builder.field("ids", ids);
@@ -190,12 +185,12 @@ protected RankDoc[] combineInnerRetrieverResults(List<ScoreDoc[]> rankResults, b
     @Override
     public boolean doEquals(Object o) {
         PinnedRetrieverBuilder that = (PinnedRetrieverBuilder) o;
-        return super.doEquals(o) && Objects.equals(ids, that.ids) && Objects.equals(docs, that.docs) && Objects.equals(type, that.type);
+        return super.doEquals(o) && Objects.equals(ids, that.ids) && Objects.equals(docs, that.docs);
     }
 
     @Override
     public int doHashCode() {
-        return Objects.hash(super.doHashCode(), ids, docs, type);
+        return Objects.hash(super.doHashCode(), ids, docs);
     }
 
     /**
@@ -225,7 +220,6 @@ public QueryBuilder explainQuery() {
 
     public void writeTo(StreamOutput out) throws IOException {
         out.writeInt(rankWindowSize());
-        out.writeString(type);
         if (out.getTransportVersion().onOrAfter(TransportVersions.PINNED_RETRIEVER)) {
             out.writeOptionalStringCollection(ids);
             if (docs.isEmpty()) {

x-pack/plugin/search-business-rules/src/test/java/org/elasticsearch/xpack/searchbusinessrules/retriever/PinnedRetrieverBuilderTests.java

@@ -176,7 +176,6 @@ public void testBwcSerialization() throws IOException {
                 assertTrue(deserialized.ids.isEmpty());
                 assertTrue(deserialized.docs.isEmpty());
                 assertEquals(builder.rankWindowSize(), deserialized.rankWindowSize());
-                assertEquals(builder.type, deserialized.type);
             }
         }
 
@@ -192,7 +191,6 @@ public void testBwcSerialization() throws IOException {
                 assertEquals(builder.ids, deserialized.ids);
                 assertEquals(builder.docs, deserialized.docs);
                 assertEquals(builder.rankWindowSize(), deserialized.rankWindowSize());
-                assertEquals(builder.type, deserialized.type);
             }
         }
     }