Surface failures when cloning test repo in gradle functional tests (#120005) (#120007)

mark-vieira · web-flow · commit 1ebcedf00e19 · 2025-01-11T11:54:55.000+11:00
diff --git a/build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/fixtures/AbstractGitAwareGradleFuncTest.groovy b/build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/fixtures/AbstractGitAwareGradleFuncTest.groovy
@@ -24,7 +24,7 @@ abstract class AbstractGitAwareGradleFuncTest extends AbstractGradleFuncTest {
 
     def setup() {
         remoteGitRepo = new File(setupGitRemote(), '.git')
-        "git clone ${remoteGitRepo.absolutePath} cloned".execute(Collections.emptyList(), testProjectDir.root).waitFor()
+        execute("git clone ${remoteGitRepo.absolutePath} cloned", testProjectDir.root)
         buildFile = new File(testProjectDir.root, 'cloned/build.gradle')
         settingsFile = new File(testProjectDir.root, 'cloned/settings.gradle')
     }

Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ abstract class AbstractGitAwareGradleFuncTest extends AbstractGradleFuncTest {`
`24`	`24`
`25`	`25`	`def setup() {`
`26`	`26`	`remoteGitRepo = new File(setupGitRemote(), '.git')`
`27`		`- "git clone ${remoteGitRepo.absolutePath} cloned".execute(Collections.emptyList(), testProjectDir.root).waitFor()`
	`27`	`+ execute("git clone ${remoteGitRepo.absolutePath} cloned", testProjectDir.root)`
`28`	`28`	`buildFile = new File(testProjectDir.root, 'cloned/build.gradle')`
`29`	`29`	`settingsFile = new File(testProjectDir.root, 'cloned/settings.gradle')`
`30`	`30`	`}`