fix test

Author: smalyshev

test/framework/src/main/java/org/elasticsearch/test/FailingFieldPlugin.java

@@ -24,12 +24,14 @@
 
 public class FailingFieldPlugin extends Plugin implements ScriptPlugin {
 
+    public static final String FAILING_FIELD_LANG = "failing_field";
+
     @Override
     public ScriptEngine getScriptEngine(Settings settings, Collection<ScriptContext<?>> contexts) {
         return new ScriptEngine() {
             @Override
             public String getType() {
-                return "failing_field";
+                return FAILING_FIELD_LANG;
             }
 
             @Override

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/AbstractPausableIntegTestCase.java

@@ -22,6 +22,8 @@
 import java.util.concurrent.Semaphore;
 import java.util.concurrent.TimeUnit;
 
+import static org.elasticsearch.xpack.esql.action.AbstractPauseFieldPlugin.PAUSE_FIELD_LANG;
+
 /** A pausable testcase. Subclasses extend this testcase to simulate slow running queries.
  *
  * Uses the evaluation of a runtime field in the mappings "pause_me" of type long, along
@@ -64,7 +66,7 @@ public void setupIndex() throws IOException {
             mapping.startObject("pause_me");
             {
                 mapping.field("type", "long");
-                mapping.startObject("script").field("source", "").field("lang", "pause").endObject();
+                mapping.startObject("script").field("source", "").field("lang", PAUSE_FIELD_LANG).endObject();
             }
             mapping.endObject();
         }

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/AbstractPauseFieldPlugin.java

@@ -28,6 +28,8 @@
  */
 public abstract class AbstractPauseFieldPlugin extends Plugin implements ScriptPlugin {
 
+    public static final String PAUSE_FIELD_LANG = "pause";
+
     // Called when the engine enters the execute() method.
     protected void onStartExecute() {}
 
@@ -39,7 +41,7 @@ public ScriptEngine getScriptEngine(Settings settings, Collection<ScriptContext<
         return new ScriptEngine() {
             @Override
             public String getType() {
-                return "pause";
+                return PAUSE_FIELD_LANG;
             }
 
             @Override

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClusterAsyncQueryIT.java

@@ -412,7 +412,7 @@ void populateRemoteIndicesWithRuntimeMapping(String clusterAlias) throws IOExcep
             mapping.startObject("const");
             {
                 mapping.field("type", "long");
-                mapping.startObject("script").field("source", "").field("lang", "pause").endObject();
+                mapping.startObject("script").field("source", "").field("lang", AbstractPauseFieldPlugin.PAUSE_FIELD_LANG).endObject();
             }
             mapping.endObject();
         }

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClustersCancellationIT.java

@@ -21,6 +21,7 @@
 import org.elasticsearch.compute.operator.exchange.ExchangeService;
 import org.elasticsearch.core.TimeValue;
 import org.elasticsearch.plugins.Plugin;
+import org.elasticsearch.tasks.TaskCancelledException;
 import org.elasticsearch.tasks.TaskInfo;
 import org.elasticsearch.test.AbstractMultiClustersTestCase;
 import org.elasticsearch.transport.TransportService;
@@ -32,6 +33,7 @@
 import java.util.ArrayList;
 import java.util.Collection;
 import java.util.List;
+import java.util.Map;
 import java.util.concurrent.TimeUnit;
 
 import static org.elasticsearch.xpack.esql.EsqlTestUtils.getValuesList;
@@ -94,7 +96,7 @@ private void createRemoteIndex(int numDocs) throws Exception {
             mapping.startObject("const");
             {
                 mapping.field("type", "long");
-                mapping.startObject("script").field("source", "").field("lang", "pause").endObject();
+                mapping.startObject("script").field("source", "").field("lang", AbstractPauseFieldPlugin.PAUSE_FIELD_LANG).endObject();
             }
             mapping.endObject();
         }
@@ -250,7 +252,7 @@ public void testCancelSkipUnavailable() throws Exception {
         request.includeCCSMetadata(true);
         PlainActionFuture<EsqlQueryResponse> requestFuture = new PlainActionFuture<>();
         client().execute(EsqlQueryAction.INSTANCE, request, requestFuture);
-        assertTrue(PauseFieldPlugin.startEmitting.await(30, TimeUnit.SECONDS));
+        assertTrue(SimplePauseFieldPlugin.startEmitting.await(30, TimeUnit.SECONDS));
         List<TaskInfo> rootTasks = new ArrayList<>();
         assertBusy(() -> {
             List<TaskInfo> tasks = client(REMOTE_CLUSTER).admin()
@@ -278,7 +280,7 @@ public void testCancelSkipUnavailable() throws Exception {
                 }
             });
         } finally {
-            PauseFieldPlugin.allowEmitting.countDown();
+            SimplePauseFieldPlugin.allowEmitting.countDown();
         }
         var resp = requestFuture.actionGet();
         EsqlExecutionInfo executionInfo = resp.getExecutionInfo();
@@ -305,8 +307,8 @@ public void testCloseSkipUnavailable() throws Exception {
             """);
         request.pragmas(randomPragmas());
         var requestFuture = client().execute(EsqlQueryAction.INSTANCE, request);
-        assertTrue(PauseFieldPlugin.startEmitting.await(30, TimeUnit.SECONDS));
-        PauseFieldPlugin.allowEmitting.countDown();
+        assertTrue(SimplePauseFieldPlugin.startEmitting.await(30, TimeUnit.SECONDS));
+        SimplePauseFieldPlugin.allowEmitting.countDown();
         cluster(REMOTE_CLUSTER).close();
         try (var resp = requestFuture.actionGet()) {
             EsqlExecutionInfo executionInfo = resp.getExecutionInfo();

x-pack/plugin/esql/src/internalClusterTest/java/org/elasticsearch/xpack/esql/action/CrossClustersQueryIT.java

@@ -27,6 +27,7 @@
 import org.elasticsearch.index.query.TermsQueryBuilder;
 import org.elasticsearch.plugins.Plugin;
 import org.elasticsearch.test.AbstractMultiClustersTestCase;
+import org.elasticsearch.test.FailingFieldPlugin;
 import org.elasticsearch.test.InternalTestCluster;
 import org.elasticsearch.test.XContentTestUtils;
 import org.elasticsearch.transport.RemoteClusterAware;
@@ -83,7 +84,7 @@ protected Collection<Class<? extends Plugin>> nodePlugins(String clusterAlias) {
         List<Class<? extends Plugin>> plugins = new ArrayList<>(super.nodePlugins(clusterAlias));
         plugins.add(EsqlPluginWithEnterpriseOrTrialLicense.class);
         plugins.add(InternalExchangePlugin.class);
-        plugins.add(EsqlNodeFailureIT.FailingFieldPlugin.class);
+        plugins.add(FailingFieldPlugin.class);
         return plugins;
     }
 
@@ -1489,7 +1490,7 @@ void populateRemoteIndicesFail(String clusterAlias, String indexName, int numSha
             mapping.startObject("fail_me");
             {
                 mapping.field("type", "long");
-                mapping.startObject("script").field("source", "").field("lang", "fail").endObject();
+                mapping.startObject("script").field("source", "").field("lang", FailingFieldPlugin.FAILING_FIELD_LANG).endObject();
             }
             mapping.endObject();
         }